Add icon custom width and height

Core/Defaults.lua

@@ -105,7 +105,8 @@ local Defaults = {
                 },
             },
             Essential = {
-                IconSize = 42,
+                IconWidth = 42,
+                IconHeight = 42,
                 Layout = {"CENTER", "CENTER", 0, -275.1},
                 Text = {
                     FontSize = 15,
@@ -114,7 +115,8 @@ local Defaults = {
                 },
             },
             Utility = {
-                IconSize = 36,
+                IconWidth = 36,
+                IconHeight = 36,
                 Layout = {"TOP", "EssentialCooldownViewer", "BOTTOM", 0, -1.1},
                 Text = {
                     FontSize = 15,
@@ -123,7 +125,8 @@ local Defaults = {
                 },
             },
             Buffs = {
-                IconSize = 32,
+                IconWidth = 32,
+                IconHeight = 32,
                 CenterBuffs = false,
                 Layout = {"BOTTOM", "BCDM_SecondaryPowerBar", "TOP", 0, 1.1},
                 Text = {
@@ -162,7 +165,8 @@ local Defaults = {
                 }
             },
             Custom = {
-                IconSize = 38,
+                IconWidth = 38,
+                IconHeight = 38,
                 FrameStrata = "LOW",
                 Layout = {"CENTER", "NONE", "CENTER", 0, 0},
                 Spacing = 1,
@@ -255,7 +259,8 @@ local Defaults = {
                 },
             },
             AdditionalCustom = {
-                IconSize = 38,
+                IconWidth = 38,
+                IconHeight = 38,
                 FrameStrata = "LOW",
                 Layout = {"CENTER", "NONE", "CENTER", 0, 0},
                 Spacing = 1,
@@ -348,7 +353,8 @@ local Defaults = {
                 },
             },
             Item = {
-                IconSize = 38,
+                IconWidth = 38,
+                IconHeight = 38,
                 FrameStrata = "LOW",
                 Layout = {"CENTER", "NONE", "CENTER", 0, 0},
                 Spacing = 1,
@@ -363,7 +369,8 @@ local Defaults = {
             },
             Trinket = {
                 Enabled = true,
-                IconSize = 38,
+                IconWidth = 38,
+                IconHeight = 38,
                 FrameStrata = "LOW",
                 Layout = {"CENTER", "NONE", "CENTER", 0, 0},
                 Spacing = 1,
@@ -377,7 +384,8 @@ local Defaults = {
                 Trinkets = {},
             },
             ItemSpell = {
-                IconSize = 38,
+                IconWidth = 38,
+                IconHeight = 38,
                 FrameStrata = "LOW",
                 Layout = {"CENTER", "NONE", "CENTER", 0, 0},
                 Spacing = 1,

Core/GUI.lua

@@ -1253,24 +1253,32 @@ local function CreateCooldownViewerSettings(parentContainer, viewerType)
     xOffsetSlider:SetValue(BCDM.db.profile.CooldownManager[viewerType].Layout[hasAnchorParent and 4 or 3])
     xOffsetSlider:SetSliderValues(-3000, 3000, 0.1)
     xOffsetSlider:SetCallback("OnValueChanged", function(self, _, value) BCDM.db.profile.CooldownManager[viewerType].Layout[hasAnchorParent and 4 or 3] = value BCDM:UpdateCooldownViewer(viewerType) end)
-    xOffsetSlider:SetRelativeWidth(isCustomViewer and 0.25 or 0.33)
+    xOffsetSlider:SetRelativeWidth(0.25)
     layoutContainer:AddChild(xOffsetSlider)
 
     local yOffsetSlider = AG:Create("Slider")
     yOffsetSlider:SetLabel("Y Offset")
     yOffsetSlider:SetValue(BCDM.db.profile.CooldownManager[viewerType].Layout[hasAnchorParent and 5 or 4])
     yOffsetSlider:SetSliderValues(-3000, 3000, 0.1)
     yOffsetSlider:SetCallback("OnValueChanged", function(self, _, value) BCDM.db.profile.CooldownManager[viewerType].Layout[hasAnchorParent and 5 or 4] = value BCDM:UpdateCooldownViewer(viewerType) end)
-    yOffsetSlider:SetRelativeWidth(isCustomViewer and 0.25 or 0.33)
+    yOffsetSlider:SetRelativeWidth(0.25)
     layoutContainer:AddChild(yOffsetSlider)
 
-    local iconSizeSlider = AG:Create("Slider")
-    iconSizeSlider:SetLabel("Icon Size")
-    iconSizeSlider:SetValue(BCDM.db.profile.CooldownManager[viewerType].IconSize)
-    iconSizeSlider:SetSliderValues(16, 128, 0.1)
-    iconSizeSlider:SetCallback("OnValueChanged", function(self, _, value) BCDM.db.profile.CooldownManager[viewerType].IconSize = value BCDM:UpdateCooldownViewer(viewerType) end)
-    iconSizeSlider:SetRelativeWidth(isCustomViewer and 0.25 or 0.33)
-    layoutContainer:AddChild(iconSizeSlider)
+    local iconWidthSlider = AG:Create("Slider")
+    iconWidthSlider:SetLabel("Icon Width")
+    iconWidthSlider:SetValue(BCDM.db.profile.CooldownManager[viewerType].IconWidth)
+    iconWidthSlider:SetSliderValues(16, 128, 0.1)
+    iconWidthSlider:SetCallback("OnValueChanged", function(self, _, value) BCDM.db.profile.CooldownManager[viewerType].IconWidth = value BCDM:UpdateCooldownViewer(viewerType) end)
+    iconWidthSlider:SetRelativeWidth(0.25)
+    layoutContainer:AddChild(iconWidthSlider)
+
+    local iconHeightSlider = AG:Create("Slider")
+    iconHeightSlider:SetLabel("Icon Height")
+    iconHeightSlider:SetValue(BCDM.db.profile.CooldownManager[viewerType].IconHeight)
+    iconHeightSlider:SetSliderValues(16, 128, 0.1)
+    iconHeightSlider:SetCallback("OnValueChanged", function(self, _, value) BCDM.db.profile.CooldownManager[viewerType].IconHeight = value BCDM:UpdateCooldownViewer(viewerType) end)
+    iconHeightSlider:SetRelativeWidth(0.25)
+    layoutContainer:AddChild(iconHeightSlider)
 
     if viewerType == "Essential" or viewerType == "Utility" or viewerType == "Buffs" then
         local infoTag = CreateInformationTag(layoutContainer, "Updates To Sizes will be applied on closing the |cFF8080FFBetter|rCooldownManager Configuration Window.")

Modules/AdditionalCustomCooldownViewer.lua

@@ -66,7 +66,7 @@ local function CreateCustomIcon(spellId)
     else
         customIcon:SetBackdropBorderColor(0, 0, 0, 1)
     end
-    customIcon:SetSize(CustomDB.IconSize, CustomDB.IconSize)
+    customIcon:SetSize(CustomDB.IconWidth, CustomDB.IconHeight)
     local anchorParent = CustomDB.Layout[2] == "NONE" and UIParent or _G[CustomDB.Layout[2]]
     customIcon:SetPoint(CustomDB.Layout[1], anchorParent, CustomDB.Layout[3], CustomDB.Layout[4], CustomDB.Layout[5])
     customIcon:RegisterEvent("SPELL_UPDATE_COOLDOWN")
@@ -117,8 +117,8 @@ local function CreateCustomIcon(spellId)
     local borderSize = BCDM.db.profile.CooldownManager.General.BorderSize
     customIcon.Icon:SetPoint("TOPLEFT", customIcon, "TOPLEFT", borderSize, -borderSize)
     customIcon.Icon:SetPoint("BOTTOMRIGHT", customIcon, "BOTTOMRIGHT", -borderSize, borderSize)
-    local iconZoom = BCDM.db.profile.CooldownManager.General.IconZoom * 0.5
-    customIcon.Icon:SetTexCoord(iconZoom, 1 - iconZoom, iconZoom, 1 - iconZoom)
+    local zoom = BCDM.db.profile.CooldownManager.General.IconZoom
+    customIcon.Icon:SetTexCoord(BCDM:CalculateTexCoords(zoom, CustomDB.IconWidth, CustomDB.IconHeight))
     customIcon.Icon:SetTexture(C_Spell.GetSpellInfo(spellId).iconID)
 
     return customIcon
@@ -186,7 +186,8 @@ local function LayoutAdditionalCustomCooldownViewer()
 
     CreateCustomIcons(AdditionalCustomCooldownViewerIcons)
 
-    local iconSize = CustomDB.IconSize
+    local iconWidth = CustomDB.IconWidth
+    local iconHeight = CustomDB.IconHeight
     local iconSpacing = CustomDB.Spacing
 
     -- Calculate and set container size first
@@ -198,11 +199,11 @@ local function LayoutAdditionalCustomCooldownViewer()
 
         local totalWidth, totalHeight = 0, 0
         if useCenteredLayout or growthDirection == "RIGHT" or growthDirection == "LEFT" then
-            totalWidth = (#AdditionalCustomCooldownViewerIcons * iconSize) + ((#AdditionalCustomCooldownViewerIcons - 1) * iconSpacing)
-            totalHeight = iconSize
+            totalWidth = (#AdditionalCustomCooldownViewerIcons * iconWidth) + ((#AdditionalCustomCooldownViewerIcons - 1) * iconSpacing)
+            totalHeight = iconHeight
         elseif growthDirection == "UP" or growthDirection == "DOWN" then
-            totalWidth = iconSize
-            totalHeight = (#AdditionalCustomCooldownViewerIcons * iconSize) + ((#AdditionalCustomCooldownViewerIcons - 1) * iconSpacing)
+            totalWidth = iconWidth
+            totalHeight = (#AdditionalCustomCooldownViewerIcons * iconHeight) + ((#AdditionalCustomCooldownViewerIcons - 1) * iconSpacing)
         end
         BCDM.AdditionalCustomCooldownViewerContainer:SetSize(totalWidth, totalHeight)
     end
@@ -223,23 +224,23 @@ local function LayoutAdditionalCustomCooldownViewer()
     local useCenteredLayout = (point == "TOP" or point == "BOTTOM") and (growthDirection == "LEFT" or growthDirection == "RIGHT")
 
     if useCenteredLayout and #AdditionalCustomCooldownViewerIcons > 0 then
-        local totalWidth = (#AdditionalCustomCooldownViewerIcons * iconSize) + ((#AdditionalCustomCooldownViewerIcons - 1) * iconSpacing)
-        local startOffset = -(totalWidth / 2) + (iconSize / 2)
+        local totalWidth = (#AdditionalCustomCooldownViewerIcons * iconWidth) + ((#AdditionalCustomCooldownViewerIcons - 1) * iconSpacing)
+        local startOffset = -(totalWidth / 2) + (iconWidth / 2)
 
         for i, spellIcon in ipairs(AdditionalCustomCooldownViewerIcons) do
             spellIcon:SetParent(BCDM.AdditionalCustomCooldownViewerContainer)
-            spellIcon:SetSize(iconSize, iconSize)
+            spellIcon:SetSize(iconWidth, iconHeight)
             spellIcon:ClearAllPoints()
 
-            local xOffset = startOffset + ((i - 1) * (iconSize + iconSpacing))
+            local xOffset = startOffset + ((i - 1) * (iconWidth + iconSpacing))
             spellIcon:SetPoint("CENTER", BCDM.AdditionalCustomCooldownViewerContainer, "CENTER", xOffset, 0)
             ApplyCooldownText()
             spellIcon:Show()
         end
     else
         for i, spellIcon in ipairs(AdditionalCustomCooldownViewerIcons) do
             spellIcon:SetParent(BCDM.AdditionalCustomCooldownViewerContainer)
-            spellIcon:SetSize(iconSize, iconSize)
+            spellIcon:SetSize(iconWidth, iconHeight)
             spellIcon:ClearAllPoints()
 
             if i == 1 then

Modules/CooldownManager.lua

@@ -24,6 +24,17 @@ local function FetchCooldownTextRegion(cooldown)
     end
 end
 
+function BCDM:CalculateTexCoords(zoom, iconWidth, iconHeight)
+    if not zoom or not iconWidth or not iconHeight or iconWidth == 0 then
+        return 0, 1, 0, 1
+    end
+
+    local aspectRatio = iconHeight / iconWidth
+    local horizontalCrop = math.max(0, (1 - (1 / aspectRatio)) / 2)
+    local verticalCrop = math.max(0, (1 - aspectRatio) / 2)
+    return zoom + horizontalCrop, 1 - zoom - horizontalCrop, zoom + verticalCrop, 1 - zoom - verticalCrop
+end
+
 -- local function FetchClassColour()
 --     local CooldownManagerDB = BCDM.db.profile
 --     local GeneralDB = CooldownManagerDB.General
@@ -208,8 +219,9 @@ local function StyleIcons()
             if childFrame then
                 if childFrame.Icon then
                     BCDM:StripTextures(childFrame.Icon)
-                    local iconZoomAmount = cooldownManagerSettings.General.IconZoom * 0.5
-                    childFrame.Icon:SetTexCoord(iconZoomAmount, 1 - iconZoomAmount, iconZoomAmount, 1 - iconZoomAmount)
+                    local zoom = cooldownManagerSettings.General.IconZoom
+                    local viewerSettings = cooldownManagerSettings[BCDM.CooldownManagerViewerToDBViewer[viewerName]]
+                    childFrame.Icon:SetTexCoord(BCDM:CalculateTexCoords(zoom, viewerSettings.IconWidth, viewerSettings.IconHeight))
                 end
                 if childFrame.Cooldown then
                     local borderSize = cooldownManagerSettings.General.BorderSize
@@ -223,7 +235,7 @@ local function StyleIcons()
                 end
                 if childFrame.CooldownFlash then childFrame.CooldownFlash:SetAlpha(0) end
                 if childFrame.DebuffBorder then childFrame.DebuffBorder:SetAlpha(0) end
-                childFrame:SetSize(cooldownManagerSettings[BCDM.CooldownManagerViewerToDBViewer[viewerName]].IconSize, cooldownManagerSettings[BCDM.CooldownManagerViewerToDBViewer[viewerName]].IconSize)
+                childFrame:SetSize(cooldownManagerSettings[BCDM.CooldownManagerViewerToDBViewer[viewerName]].IconWidth, cooldownManagerSettings[BCDM.CooldownManagerViewerToDBViewer[viewerName]].IconHeight)
                 BCDM:AddBorder(childFrame)
                 if not childFrame.layoutIndex then childFrame:SetShown(false) end
             end
@@ -363,7 +375,8 @@ function BCDM:UpdateCooldownViewer(viewerType)
         if childFrame then
             if childFrame.Icon and ShouldSkin() then
                 BCDM:StripTextures(childFrame.Icon)
-                childFrame.Icon:SetTexCoord(cooldownManagerSettings.General.IconZoom, 1 - cooldownManagerSettings.General.IconZoom, cooldownManagerSettings.General.IconZoom, 1 - cooldownManagerSettings.General.IconZoom)
+                local zoom = cooldownManagerSettings.General.IconZoom
+                childFrame.Icon:SetTexCoord(BCDM:CalculateTexCoords(zoom, cooldownManagerSettings[viewerType].IconWidth, cooldownManagerSettings[viewerType].IconHeight))
             end
             if childFrame.Cooldown then
                 childFrame.Cooldown:ClearAllPoints()
@@ -375,7 +388,7 @@ function BCDM:UpdateCooldownViewer(viewerType)
                 childFrame.Cooldown:SetSwipeTexture("Interface\\Buttons\\WHITE8X8")
             end
             if childFrame.CooldownFlash then childFrame.CooldownFlash:SetAlpha(0) end
-            childFrame:SetSize(cooldownManagerSettings[viewerType].IconSize, cooldownManagerSettings[viewerType].IconSize)
+            childFrame:SetSize(cooldownManagerSettings[viewerType].IconWidth, cooldownManagerSettings[viewerType].IconHeight)
         end
     end
 

Modules/CustomCooldownViewer.lua

@@ -65,7 +65,7 @@ local function CreateCustomIcon(spellId)
     else
         customIcon:SetBackdropBorderColor(0, 0, 0, 1)
     end
-    customIcon:SetSize(CustomDB.IconSize, CustomDB.IconSize)
+    customIcon:SetSize(CustomDB.IconWidth, CustomDB.IconHeight)
     local anchorParent = CustomDB.Layout[2] == "NONE" and UIParent or _G[CustomDB.Layout[2]]
     customIcon:SetPoint(CustomDB.Layout[1], anchorParent, CustomDB.Layout[3], CustomDB.Layout[4], CustomDB.Layout[5])
     customIcon:RegisterEvent("SPELL_UPDATE_COOLDOWN")
@@ -114,8 +114,8 @@ local function CreateCustomIcon(spellId)
     local borderSize = BCDM.db.profile.CooldownManager.General.BorderSize
     customIcon.Icon:SetPoint("TOPLEFT", customIcon, "TOPLEFT", borderSize, -borderSize)
     customIcon.Icon:SetPoint("BOTTOMRIGHT", customIcon, "BOTTOMRIGHT", -borderSize, borderSize)
-    local iconZoom = BCDM.db.profile.CooldownManager.General.IconZoom * 0.5
-    customIcon.Icon:SetTexCoord(iconZoom, 1 - iconZoom, iconZoom, 1 - iconZoom)
+    local zoom = BCDM.db.profile.CooldownManager.General.IconZoom
+    customIcon.Icon:SetTexCoord(BCDM:CalculateTexCoords(zoom, CustomDB.IconWidth, CustomDB.IconHeight))
     customIcon.Icon:SetTexture(C_Spell.GetSpellInfo(spellId).iconID)
 
     return customIcon
@@ -183,7 +183,8 @@ local function LayoutCustomCooldownViewer()
 
     CreateCustomIcons(customCooldownViewerIcons)
 
-    local iconSize = CustomDB.IconSize
+    local iconWidth = CustomDB.IconWidth
+    local iconHeight = CustomDB.IconHeight
     local iconSpacing = CustomDB.Spacing
 
     -- Calculate and set container size first
@@ -195,11 +196,11 @@ local function LayoutCustomCooldownViewer()
 
         local totalWidth, totalHeight = 0, 0
         if useCenteredLayout or growthDirection == "RIGHT" or growthDirection == "LEFT" then
-            totalWidth = (#customCooldownViewerIcons * iconSize) + ((#customCooldownViewerIcons - 1) * iconSpacing)
-            totalHeight = iconSize
+            totalWidth = (#customCooldownViewerIcons * iconWidth) + ((#customCooldownViewerIcons - 1) * iconSpacing)
+            totalHeight = iconHeight
         elseif growthDirection == "UP" or growthDirection == "DOWN" then
-            totalWidth = iconSize
-            totalHeight = (#customCooldownViewerIcons * iconSize) + ((#customCooldownViewerIcons - 1) * iconSpacing)
+            totalWidth = iconWidth
+            totalHeight = (#customCooldownViewerIcons * iconHeight) + ((#customCooldownViewerIcons - 1) * iconSpacing)
         end
         BCDM.CustomCooldownViewerContainer:SetSize(totalWidth, totalHeight)
     end
@@ -220,23 +221,23 @@ local function LayoutCustomCooldownViewer()
     local useCenteredLayout = (point == "TOP" or point == "BOTTOM") and (growthDirection == "LEFT" or growthDirection == "RIGHT")
 
     if useCenteredLayout and #customCooldownViewerIcons > 0 then
-        local totalWidth = (#customCooldownViewerIcons * iconSize) + ((#customCooldownViewerIcons - 1) * iconSpacing)
-        local startOffset = -(totalWidth / 2) + (iconSize / 2)
+        local totalWidth = (#customCooldownViewerIcons * iconWidth) + ((#customCooldownViewerIcons - 1) * iconSpacing)
+        local startOffset = -(totalWidth / 2) + (iconWidth / 2)
 
         for i, spellIcon in ipairs(customCooldownViewerIcons) do
             spellIcon:SetParent(BCDM.CustomCooldownViewerContainer)
-            spellIcon:SetSize(iconSize, iconSize)
+            spellIcon:SetSize(iconWidth, iconHeight)
             spellIcon:ClearAllPoints()
 
-            local xOffset = startOffset + ((i - 1) * (iconSize + iconSpacing))
+            local xOffset = startOffset + ((i - 1) * (iconWidth + iconSpacing))
             spellIcon:SetPoint("CENTER", BCDM.CustomCooldownViewerContainer, "CENTER", xOffset, 0)
             ApplyCooldownText()
             spellIcon:Show()
         end
     else
         for i, spellIcon in ipairs(customCooldownViewerIcons) do
             spellIcon:SetParent(BCDM.CustomCooldownViewerContainer)
-            spellIcon:SetSize(iconSize, iconSize)
+            spellIcon:SetSize(iconWidth, iconHeight)
             spellIcon:ClearAllPoints()
 
             if i == 1 then