Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EGON] Week9 Solutions #525

Merged
merged 6 commits into from
Oct 12, 2024
Merged

[EGON] Week9 Solutions #525

merged 6 commits into from
Oct 12, 2024

Conversation

EgonD3V
Copy link
Contributor

@EgonD3V EgonD3V commented Oct 11, 2024 •
edited
Loading

답안 제출 문제

체크 리스트

  • PR을 프로젝트에 추가하고 Week를 현재 주차로 설정해주세요.
  • 바로 앞에 PR을 열어주신 분을 코드 검토자로 지정해주세요.
  • 문제를 모두 푸시면 프로젝트에서 Status를 In Review로 설정해주세요.
  • 코드 검토자 1분 이상으로부터 승인을 받으셨다면 PR을 병합해주세요.

@EgonD3V EgonD3V added the py label Oct 11, 2024
@EgonD3V EgonD3V requested a review from mangodm-web October 11, 2024 00:16
@EgonD3V EgonD3V self-assigned this Oct 11, 2024
@EgonD3V EgonD3V requested a review from a team as a code owner October 11, 2024 00:16
EgonD3V
EgonD3V commented Oct 11, 2024
View reviewed changes
maximum-subarray/EGON.py
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maximum-product-subarray 파일이 여기에 잘못 들어있었어서 수정했습니다. code diff 때문에 보기 힘드실텐데, 오른쪽의 "View file"을 통해 파일 단위로 리뷰 부탁드립니다.

@DaleSeo DaleSeo mentioned this pull request Oct 12, 2024
Merged
6 tasks
mangodm-web
mangodm-web approved these changes Oct 12, 2024
View reviewed changes
Copy link
Contributor

@mangodm-web mangodm-web left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

안녕하세요, EGON님!
먼저 코드 리뷰가 늦어서 죄송합니다. 🙏

깔끔하게 코드를 잘 작성해주셔서 따로 코멘트 남길 부분이 없네요. 이번주에 저는 못 푼 문제가 많은데, 보면서 좋은 접근 방향들을 알게된 것 같아요. 감사합니다! 남은 주들도 화이팅입니다! 💪

@EgonD3V EgonD3V merged commit 0ef1547 into DaleStudy:main Oct 12, 2024
3 checks passed
@EgonD3V EgonD3V changed the title [EGON]] Week9 Solutions [EGON] Week9 Solutions Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mangodm-web mangodm-web mangodm-web approved these changes

Assignees

@EgonD3V EgonD3V

Labels
py
Projects
No open projects
리트코드 스터디 2기
Status: Completed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EgonD3V @mangodm-web