Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bus710] Week 02 #746

Merged
merged 3 commits into from
Dec 21, 2024
Merged

[bus710] Week 02 #746

merged 3 commits into from
Dec 21, 2024

Conversation

bus710
Copy link
Contributor

@bus710 bus710 commented Dec 19, 2024

답안 제출 문제

체크 리스트

  • 우측 메뉴에서 PR을 Projects에 추가해주세요.
  • Projects의 오른쪽 버튼(▼)을 눌러 확장한 뒤, Week를 현재 주차로 설정해주세요.
  • 바로 앞에 PR을 열어주신 분을 코드 검토자로 지정해주세요.
  • 문제를 모두 푸시면 프로젝트에서 StatusIn Review로 설정해주세요.
  • 코드 검토자 1분 이상으로부터 승인을 받으셨다면 PR을 병합해주세요.

@bus710 bus710 requested a review from a team as a code owner December 19, 2024 00:02
@github-actions github-actions bot added the rust label Dec 19, 2024
@bus710 bus710 requested a review from Zioq December 20, 2024 07:36
Copy link
Contributor

@EgonD3V EgonD3V left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2주차도 수고 많으셨습니다 go 언어 매력있는 것 같아요 3주차도 화이팅

Comment on lines +1 to +2
// Space complexity: O(2n) - 주어진 한 단어안의 각 문자가 서로 다 다를 경우 생성한 맵들의 최대 길이는 주어진 단어만큼이므로 2n
// Time complexity: O(3n) - 각 맵을 생성하고 추가로 각 아이템을 비교하는 루프가 필요하므로 3n
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

복잡도 계산에서 상수 계수는 표기하지 않으셔도 괜찮습니다

Comment on lines +28 to +32
let result = count_bits(2);
assert_eq!(result, Vec::from([0, 1, 1]));

let result2 = count_bits(5);
assert_eq!(result2, Vec::from([0, 1, 1, 2, 1, 2]));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

두 테스트 케이스를 한 함수에 넣기 보다는 각각 나누시는 편이 좋을 것 같습니다

@bus710 bus710 merged commit 82d87ff into DaleStudy:main Dec 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

2 participants