ID-721 Update Terra Notebook Utils to 0.13.0 #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LizBaldo
approved these changes
Sep 25, 2023
There was a problem hiding this comment.
I can't thank you enough for working through that 🙏
You should be able to merge and then follow the rest of the instructions here: https://broadworkbench.atlassian.net/wiki/spaces/IA/pages/2519564289/Integrating+new+Terra+docker+images+with+Leonardo
I am UL this week for IA and can help out with all of it
| @@ -212,16 +213,27 @@ RUN mkdir -p /tmp/jellyfish && \ | |||
| cd $HOME && \ | |||
| rm -rf /tmp/jellyfish | |||
|
|
|||
| # Install Cereal headers (dependency of pangenie) | |||
There was a problem hiding this comment.
Thanks for fixing that :)
| # Avoid notebook extension issues | ||
| && pip3 install "nbclassic<0.5" \ | ||
| # for jupyter_delocalize.py and jupyter_notebook_config.py | ||
| && pip3 install requests \ | ||
| && pip3 install firecloud \ | ||
| && pip3 install terra-notebook-utils \ | ||
| && pip3 install terra-notebook-utils==0.13.0 \ |
There was a problem hiding this comment.
I promise next time, this will be the only line to change!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://broadworkbench.atlassian.net/browse/ID-721
Updating TNU to
0.13.0so that the DRSHub can be used instead of Martha. If TNU sees aDRS_RESOLVER_ENDPOINTenvironment variable, it will talk to DRSHub at the specified endpoint for DRS resolutions. If the env var is not provided, TNU will default back to Martha.Looks like I had to update all the images!