Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nvidia NIM Integration #18964

Merged
merged 13 commits into from
Nov 27, 2024
Merged

Nvidia NIM Integration #18964

merged 13 commits into from
Nov 27, 2024

Conversation

Kyle-Neale
Copy link
Contributor

@Kyle-Neale Kyle-Neale commented Oct 31, 2024 •
edited
Loading

What does this PR do?

https://datadoghq.atlassian.net/browse/AI-4438

Motivation

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@datadog-agent-integrations-bot datadog-agent-integrations-bot bot added documentation release qa/skip-qa Automatically skip this PR for the next QA labels Oct 31, 2024
@github-actions GitHub Actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@github-actions GitHub Actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@github-actions GitHub Actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@codecov Codecov
Copy link

codecov bot commented Oct 31, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 93.10345% with 6 lines in your changes missing coverage. Please review.

Project coverage is 88.31%. Comparing base (686abf2) to head (47de324).
Report is 38 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
hive ?
hivemq ?
ignite ?
jboss_wildfly ?
kafka ?
nvidia_nim 93.10% <93.10%> (?)
presto ?
slurm ?
solr ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@Kyle-Neale Kyle-Neale changed the title Create Nvidia NIM scaffolding Nvidia NIM Integration Oct 31, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2024

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2024

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

steveny91 and others added 2 commits November 19, 2024 09:28
@steveny91
nvidia dash (#19074)
08738a7 
* nvidia dash

* nits

* more nits

* nit
@Kyle-Neale
validate-assets fixes
af0725a
@Kyle-Neale Kyle-Neale marked this pull request as ready for review November 20, 2024 19:56
@Kyle-Neale Kyle-Neale requested review from a team as code owners November 20, 2024 19:56
steveny91
steveny91 reviewed Nov 21, 2024
View reviewed changes
nvidia_nim/metadata.csv Outdated Show resolved Hide resolved
@Kyle-Neale @steveny91
Update metadata desciption for process.start_time_seconds
6702c3d 
Co-authored-by: Steven Yuen <steven.yuen@datadoghq.com>
steveny91
steveny91 previously approved these changes Nov 22, 2024
View reviewed changes
hestonhoffman
hestonhoffman previously approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@hestonhoffman hestonhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some suggestions

nvidia_nim/README.md Outdated Show resolved Hide resolved
nvidia_nim/README.md Outdated Show resolved Hide resolved
nvidia_nim/README.md Show resolved Hide resolved
nvidia_nim/metadata.csv Outdated Show resolved Hide resolved
nvidia_nim/metadata.csv Outdated Show resolved Hide resolved
nvidia_nim/metadata.csv Outdated Show resolved Hide resolved
nvidia_nim/metadata.csv Outdated Show resolved Hide resolved
nvidia_nim/manifest.json
"manifest_version": "2.0.0",
"app_uuid": "c7307eb9-7bbf-4dae-b74f-6396bf5bf514",
"app_id": "nvidia-nim",
"display_on_public_website": false,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"display_on_public_website": false,
"display_on_public_website": false,

Just a heads up that this is set to false in case you want this to be published to the docs site.

@hestonhoffman hestonhoffman dismissed their stale review November 26, 2024 18:38

Oops, meant to comment

@Kyle-Neale Kyle-Neale force-pushed the kyle.neale/nvidia-nim-integration branch from 67650b5 to 47de324 Compare November 27, 2024 14:11
@Kyle-Neale Kyle-Neale added this pull request to the merge queue Nov 27, 2024
Merged via the queue into master with commit 83fb160 Nov 27, 2024
47 of 48 checks passed
@Kyle-Neale Kyle-Neale deleted the kyle.neale/nvidia-nim-integration branch November 27, 2024 17:22
github-actions bot pushed a commit that referenced this pull request Nov 27, 2024
@github-merge-queue
Nvidia NIM Integration (#18964)
d6336bb 
* Create Nvidia NIM scaffolding

* Add Initial Release changelog

* sync models and config

* Add metadata and tests

* Add Readme

* nvidia dash (#19074)

* nvidia dash

* nits

* more nits

* nit

* validate-assets fixes

* remove astericks in README hyperlink ref

* Address nits

* Update metadata desciption for process.start_time_seconds

Co-authored-by: Steven Yuen <steven.yuen@datadoghq.com>

* Add documentation nits

* Final nits

---------

Co-authored-by: Steven Yuen <steven.yuen@datadoghq.com> 83fb160
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estherk15 estherk15 estherk15 approved these changes

@steveny91 steveny91 steveny91 approved these changes

@hestonhoffman hestonhoffman hestonhoffman left review comments

Assignees
No one assigned
Labels
agent/approved dev/testing dev/tooling docs/approved documentation ecosystems/review-requested editorial review Waiting on a more in-depth review from a docs team editor integration/nvidia_nim product/review-requested qa/skip-qa Automatically skip this PR for the next QA release team/agent-integrations team/documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Kyle-Neale @steveny91 @hestonhoffman @estherk15 @jhgilbert