parametric: enable nodejs otel metrics #5534
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Add OpenTelemetry metrics API support to Node.js parametric server for cross-language testing and fix type preservation issues that could cause incorrect int/double handling in OTLP exports.
Changes
Added OTel Metrics Endpoints to Node.js Parametric Server (
server.js
)Implemented 13 endpoints matching the Python parametric server:
get_meter
,force_flush
create_counter
,counter_add
,create_updowncounter
,updowncounter_add
,create_gauge
,gauge_record
,create_histogram
,histogram_record
create_asynchronous_counter
,create_asynchronous_updowncounter
,create_asynchronous_gauge
Fixed OpenTelemetry API Module Singleton Issue (
package.json
)Added npm overrides to ensure single
@opentelemetry/api
instance, preventing MeterProvider registration failures:Fixed Type Preservation (
server.py
)Reordered Pydantic Union types from
Union[float, int]
→Union[int, float]
in all metric value fields (10 models + 3 functions). This ensures:42
stays asint
→ OTLPasInt
(sfixed64)42.0
stays asfloat
→ OTLPasDouble
Critical for correct OTLP protocol compliance.
Cleanup
Removed debug print statements.
Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
[<language>]
, double-check that only<language>
is impacted by the changebuild-XXX-image
label is present