Skip to content

parametric: make otel metrics tests compatible with nodejs #5534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 21, 2025
Merged

parametric: make otel metrics tests compatible with nodejs #5534

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4172618
parametric: enable nodejs otel metrics
mabdinur Oct 16, 2025
857cae7
skip node tests
mabdinur Oct 16, 2025
1df6f3c
fmt
mabdinur Oct 16, 2025
f9204a9
Merge branch 'main' into munir/otel-metrics-nodejs
mabdinur Oct 20, 2025
c6715bf
Merge branch 'main' into munir/otel-metrics-nodejs
mabdinur Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 6 additions & 13 deletions tests/parametric/test_otel_metrics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ def assert_sum_aggregation(sum_aggregation, aggregation_temporality, is_monotoni

for sum_data_point in sum_aggregation["data_points"]:
if attributes == {item["key"]: item["value"]["string_value"] for item in sum_data_point["attributes"]}:
assert sum_data_point["as_double"] == value
assert float(sum_data_point.get("as_int", 0)) == value
assert (
attributes.items()
== {item["key"]: item["value"]["string_value"] for item in sum_data_point["attributes"]}.items()
Expand All @@ -120,7 +120,7 @@ def assert_sum_aggregation(sum_aggregation, aggregation_temporality, is_monotoni
def assert_gauge_aggregation(gauge_aggregation, value, attributes):
for gauge_data_point in gauge_aggregation["data_points"]:
if attributes == {item["key"]: item["value"]["string_value"] for item in gauge_data_point["attributes"]}:
assert gauge_data_point["as_double"] == value
assert float(gauge_data_point.get("as_int", 0)) == value
assert "time_unix_nano" in gauge_data_point
return

Expand Down Expand Up @@ -180,7 +180,6 @@ def get_expected_bucket_counts(entries: list[int], bucket_boundaries: list[float
@missing_feature(context.library == "dotnet", reason="Not yet implemented", force_skip=True)
@missing_feature(context.library == "golang", reason="Not yet implemented", force_skip=True)
@missing_feature(context.library == "java", reason="Not yet implemented", force_skip=True)
@missing_feature(context.library == "nodejs", reason="Not yet implemented", force_skip=True)
@missing_feature(context.library == "php", reason="Not yet implemented", force_skip=True)
@missing_feature(context.library == "ruby", reason="Not yet implemented", force_skip=True)
@missing_feature(context.library == "rust", reason="Not yet implemented", force_skip=True)
Expand Down Expand Up @@ -249,7 +248,6 @@ def test_otlp_metrics_disabled(self, test_agent, test_library, library_env):
@missing_feature(context.library == "dotnet", reason="Not yet implemented", force_skip=True)
@missing_feature(context.library == "golang", reason="Not yet implemented", force_skip=True)
@missing_feature(context.library == "java", reason="Not yet implemented", force_skip=True)
@missing_feature(context.library == "nodejs", reason="Not yet implemented", force_skip=True)
@missing_feature(context.library == "php", reason="Not yet implemented", force_skip=True)
@missing_feature(context.library == "ruby", reason="Not yet implemented", force_skip=True)
@missing_feature(context.library == "rust", reason="Not yet implemented", force_skip=True)
Expand Down Expand Up @@ -322,7 +320,6 @@ def test_otel_get_meter_by_distinct(self, test_agent, test_library, library_env)
@missing_feature(context.library == "dotnet", reason="Not yet implemented", force_skip=True)
@missing_feature(context.library == "golang", reason="Not yet implemented", force_skip=True)
@missing_feature(context.library == "java", reason="Not yet implemented", force_skip=True)
@missing_feature(context.library == "nodejs", reason="Not yet implemented", force_skip=True)
@missing_feature(context.library == "php", reason="Not yet implemented", force_skip=True)
@missing_feature(context.library == "ruby", reason="Not yet implemented", force_skip=True)
@missing_feature(context.library == "rust", reason="Not yet implemented", force_skip=True)
Expand Down Expand Up @@ -542,7 +539,6 @@ def test_otel_create_instruments_by_distinct(self, test_agent, test_library, lib
@missing_feature(context.library == "dotnet", reason="Not yet implemented", force_skip=True)
@missing_feature(context.library == "golang", reason="Not yet implemented", force_skip=True)
@missing_feature(context.library == "java", reason="Not yet implemented", force_skip=True)
@missing_feature(context.library == "nodejs", reason="Not yet implemented", force_skip=True)
@missing_feature(context.library == "php", reason="Not yet implemented", force_skip=True)
@missing_feature(context.library == "ruby", reason="Not yet implemented", force_skip=True)
@missing_feature(context.library == "rust", reason="Not yet implemented", force_skip=True)
Expand Down Expand Up @@ -1071,7 +1067,6 @@ def test_otel_asynchronous_gauge_constant_callback_value(self, test_agent, test_
@missing_feature(context.library == "dotnet", reason="Not yet implemented", force_skip=True)
@missing_feature(context.library == "golang", reason="Not yet implemented", force_skip=True)
@missing_feature(context.library == "java", reason="Not yet implemented", force_skip=True)
@missing_feature(context.library == "nodejs", reason="Not yet implemented", force_skip=True)
@missing_feature(context.library == "php", reason="Not yet implemented", force_skip=True)
@missing_feature(context.library == "ruby", reason="Not yet implemented", force_skip=True)
@missing_feature(context.library == "rust", reason="Not yet implemented", force_skip=True)
Expand Down Expand Up @@ -1263,7 +1258,6 @@ def test_otel_aggregation_temporality(self, library_env, test_agent, test_librar
@missing_feature(context.library == "dotnet", reason="Not yet implemented", force_skip=True)
@missing_feature(context.library == "golang", reason="Not yet implemented", force_skip=True)
@missing_feature(context.library == "java", reason="Not yet implemented", force_skip=True)
@missing_feature(context.library == "nodejs", reason="Not yet implemented", force_skip=True)
@missing_feature(context.library == "php", reason="Not yet implemented", force_skip=True)
@missing_feature(context.library == "ruby", reason="Not yet implemented", force_skip=True)
@missing_feature(context.library == "rust", reason="Not yet implemented", force_skip=True)
Expand Down Expand Up @@ -1309,6 +1303,7 @@ def test_otlp_custom_endpoint_http_protobuf(
scope_metrics = metrics[0]["resource_metrics"][0]["scope_metrics"]
assert scope_metrics is not None

@missing_feature(context.library == "nodejs", reason="Does not support grpc")
@pytest.mark.parametrize(
("library_env", "endpoint_env", "test_agent_otlp_grpc_port"),
[
Expand Down Expand Up @@ -1379,6 +1374,7 @@ def test_otlp_metrics_custom_endpoint_http_protobuf(
scope_metrics = metrics[0]["resource_metrics"][0]["scope_metrics"]
assert scope_metrics is not None

@missing_feature(context.library == "nodejs", reason="Does not support grpc")
@pytest.mark.parametrize(
("library_env", "endpoint_env", "test_agent_otlp_grpc_port"),
[
Expand Down Expand Up @@ -1421,7 +1417,6 @@ def test_otlp_metrics_custom_endpoint_grpc(
@missing_feature(context.library == "dotnet", reason="Not yet implemented", force_skip=True)
@missing_feature(context.library == "golang", reason="Not yet implemented", force_skip=True)
@missing_feature(context.library == "java", reason="Not yet implemented", force_skip=True)
@missing_feature(context.library == "nodejs", reason="Not yet implemented", force_skip=True)
@missing_feature(context.library == "php", reason="Not yet implemented", force_skip=True)
@missing_feature(context.library == "ruby", reason="Not yet implemented", force_skip=True)
@missing_feature(context.library == "rust", reason="Not yet implemented", force_skip=True)
Expand Down Expand Up @@ -1501,7 +1496,6 @@ def test_custom_metrics_http_headers_included_in_otlp_export(self, test_agent, t
@missing_feature(context.library == "dotnet", reason="Not yet implemented", force_skip=True)
@missing_feature(context.library == "golang", reason="Not yet implemented", force_skip=True)
@missing_feature(context.library == "java", reason="Not yet implemented", force_skip=True)
@missing_feature(context.library == "nodejs", reason="Not yet implemented", force_skip=True)
@missing_feature(context.library == "php", reason="Not yet implemented", force_skip=True)
@missing_feature(context.library == "ruby", reason="Not yet implemented", force_skip=True)
@missing_feature(context.library == "rust", reason="Not yet implemented", force_skip=True)
Expand Down Expand Up @@ -1578,7 +1572,7 @@ def test_otlp_protocol_grpc(self, test_agent, test_library, library_env):
@missing_feature(context.library == "dotnet", reason="Not yet implemented", force_skip=True)
@missing_feature(context.library == "golang", reason="Not yet implemented", force_skip=True)
@missing_feature(context.library == "java", reason="Not yet implemented", force_skip=True)
@missing_feature(context.library == "nodejs", reason="Not yet implemented", force_skip=True)
@missing_feature(context.library == "nodejs", reason="Does not support DD_HOSTNAME")
@missing_feature(context.library == "php", reason="Not yet implemented", force_skip=True)
@missing_feature(context.library == "ruby", reason="Not yet implemented", force_skip=True)
@missing_feature(context.library == "rust", reason="Not yet implemented", force_skip=True)
Expand Down Expand Up @@ -1676,7 +1670,6 @@ def test_hostname_omitted(self, test_agent, test_library, library_env):
@missing_feature(context.library == "dotnet", reason="Not yet implemented", force_skip=True)
@missing_feature(context.library == "golang", reason="Not yet implemented", force_skip=True)
@missing_feature(context.library == "java", reason="Not yet implemented", force_skip=True)
@missing_feature(context.library == "nodejs", reason="Not yet implemented", force_skip=True)
@missing_feature(context.library == "php", reason="Not yet implemented", force_skip=True)
@missing_feature(context.library == "ruby", reason="Not yet implemented", force_skip=True)
@missing_feature(context.library == "rust", reason="Not yet implemented", force_skip=True)
Expand Down Expand Up @@ -1827,7 +1820,6 @@ def test_dd_env_vars_override_otel(self, test_agent, test_library):
@missing_feature(context.library == "dotnet", reason="Not yet implemented", force_skip=True)
@missing_feature(context.library == "golang", reason="Not yet implemented", force_skip=True)
@missing_feature(context.library == "java", reason="Not yet implemented", force_skip=True)
@missing_feature(context.library == "nodejs", reason="Not yet implemented", force_skip=True)
@missing_feature(context.library == "php", reason="Not yet implemented", force_skip=True)
@missing_feature(context.library == "ruby", reason="Not yet implemented", force_skip=True)
@missing_feature(context.library == "rust", reason="Not yet implemented", force_skip=True)
Expand Down Expand Up @@ -2026,6 +2018,7 @@ def test_telemetry_metrics_http_protobuf(self, library_env, test_agent, test_lib
assert "protocol:http" in metric.get("tags")
assert "encoding:protobuf" in metric.get("tags")

@missing_feature(context.library == "nodejs", reason="Does not support grpc", force_skip=True)
@pytest.mark.parametrize(
"library_env",
[
Expand Down
3 changes: 3 additions & 0 deletions utils/build/docker/nodejs/parametric/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,8 @@
"@opentelemetry/api": "^1.9.0",
"@opentelemetry/core": "^1.25.1",
"express": "^4.18.2"
},
"overrides": {
"@opentelemetry/api": "$@opentelemetry/api"
}
}
Loading
Loading