Code

58 revise layer distribution#59

Code

Merged

erwin-mulder merged 14 commits intodevelopmentDeltares-research/libzsf:developmentfrom 58-revise-layer-distributionDeltares-research/libzsf:58-revise-layer-distributionCopy head branch name to clipboardJan 22, 2025

+244-138

Commits

Commits on Dec 5, 2024

• Ignore profiles for salinity, simply add by volumes.

  erwin-mulder

  committed
  14d1dc8

  Copy full SHA for 14d1dc8

• Rewrite of layer distribution, taking into account the sign of the quantity in relation to the profile.

  erwin-mulder

  committed
  3268d47

  Copy full SHA for 3268d47

• Removed usage of profiles for concentration quantities (salinity).

  erwin-mulder

  committed
  a1f18a5

  Copy full SHA for a1f18a5

• Improved logging of salinity layers.

  erwin-mulder

  committed
  189dc3b

  Copy full SHA for 189dc3b

Commits on Dec 10, 2024

• Split volumes in 'to' and 'from' parts, we use proper volumes for the configured laterals.

  erwin-mulder

  committed
  711a83e

  Copy full SHA for 711a83e

• Added masking for salinity layers based on discharge result.

  erwin-mulder

  committed
  e41cb84

  Copy full SHA for e41cb84

• Fixed typo from->to.

  erwin-mulder

  committed
  c7c7f36

  Copy full SHA for c7c7f36

• Fixed quantity names for get

  erwin-mulder

  committed
  826bac0

  Copy full SHA for 826bac0

Commits on Dec 17, 2024

• Renamed variables to adhere to new terminology.

  erwin-mulder

  committed
  9a3e5c3

  Copy full SHA for 9a3e5c3

Commits on Dec 18, 2024

• Fixed log message for phase wise update step.

  erwin-mulder

  committed
  c476452

  Copy full SHA for c476452

Commits on Dec 19, 2024

• Made open phasse a a bit more lenient towards inner and outer head differences (max 1cm), also made the delta_time check towards time steps and phase-wise phase lengths a bit more strict to prevent…

  Show description for b603f91
  erwin-mulder

  committed
  b603f91

  Copy full SHA for b603f91

Commits on Jan 7, 2025

• Fixed division by zero while correcting phase values in case lake or sea volumes are zero in phases where that door is closed.

  erwin-mulder

  committed
  65aba47

  Copy full SHA for 65aba47

Commits on Jan 21, 2025

• Addressed PR 58 review comments.

  erwin-mulder

  committed
  5c4e34f

  Copy full SHA for 5c4e34f

• Typo in comment

  erwin-mulder

  committed
  79b2b1d

  Copy full SHA for 79b2b1d