Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roll back bluesky version #1083

Merged
merged 3 commits into from
Mar 3, 2025
Merged

Roll back bluesky version #1083

merged 3 commits into from
Mar 3, 2025

Conversation

DominicOram
Copy link
Contributor

Fixes #1082

Instructions to reviewer on how to test:

  1. Confirm tests still pass

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

Copy link

codecov bot commented Mar 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.69%. Comparing base (a3b1b8c) to head (b119d38).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1083      +/-   ##
==========================================
- Coverage   97.69%   97.69%   -0.01%     
==========================================
  Files         160      160              
  Lines        6638     6635       -3     
==========================================
- Hits         6485     6482       -3     
  Misses        153      153              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DominicOram DominicOram marked this pull request as ready for review March 3, 2025 17:39
@DominicOram DominicOram requested a review from a team as a code owner March 3, 2025 17:39
Copy link
Collaborator

@olliesilvester olliesilvester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😢

@DominicOram DominicOram merged commit e3ec09d into main Mar 3, 2025
19 checks passed
@DominicOram DominicOram deleted the 1082_roll_back_bluesky branch March 3, 2025 18:16
DominicOram added a commit that referenced this pull request Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Roll back to bluesky 1.13
2 participants