Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more structure to controllers #51

Merged
merged 7 commits into from
Oct 17, 2024

Fix tests for new structure

7f70499
Select commit
Loading
Failed to load commit list.
Merged

Add more structure to controllers #51

Fix tests for new structure
7f70499
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Oct 15, 2024 in 1s

67.67% of diff hit (target 68.82%)

View this Pull Request on Codecov

67.67% of diff hit (target 68.82%)

Annotations

Check warning on line 68 in src/fastcs_eiger/eiger_controller.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/fastcs_eiger/eiger_controller.py#L68

Added line #L68 was not covered by tests

Check warning on line 70 in src/fastcs_eiger/eiger_controller.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/fastcs_eiger/eiger_controller.py#L70

Added line #L70 was not covered by tests

Check warning on line 73 in src/fastcs_eiger/eiger_controller.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/fastcs_eiger/eiger_controller.py#L72-L73

Added lines #L72 - L73 were not covered by tests

Check warning on line 76 in src/fastcs_eiger/eiger_controller.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/fastcs_eiger/eiger_controller.py#L76

Added line #L76 was not covered by tests

Check warning on line 89 in src/fastcs_eiger/eiger_controller.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/fastcs_eiger/eiger_controller.py#L89

Added line #L89 was not covered by tests

Check warning on line 92 in src/fastcs_eiger/eiger_controller.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/fastcs_eiger/eiger_controller.py#L92

Added line #L92 was not covered by tests

Check warning on line 218 in src/fastcs_eiger/eiger_controller.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/fastcs_eiger/eiger_controller.py#L218

Added line #L218 was not covered by tests

Check warning on line 228 in src/fastcs_eiger/eiger_controller.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/fastcs_eiger/eiger_controller.py#L222-L228

Added lines #L222 - L228 were not covered by tests

Check warning on line 232 in src/fastcs_eiger/eiger_controller.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/fastcs_eiger/eiger_controller.py#L232

Added line #L232 was not covered by tests

Check warning on line 236 in src/fastcs_eiger/eiger_controller.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/fastcs_eiger/eiger_controller.py#L236

Added line #L236 was not covered by tests

Check warning on line 240 in src/fastcs_eiger/eiger_controller.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/fastcs_eiger/eiger_controller.py#L240

Added line #L240 was not covered by tests

Check warning on line 245 in src/fastcs_eiger/eiger_controller.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/fastcs_eiger/eiger_controller.py#L245

Added line #L245 was not covered by tests

Check warning on line 249 in src/fastcs_eiger/eiger_controller.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/fastcs_eiger/eiger_controller.py#L248-L249

Added lines #L248 - L249 were not covered by tests

Check warning on line 254 in src/fastcs_eiger/eiger_controller.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/fastcs_eiger/eiger_controller.py#L254

Added line #L254 was not covered by tests

Check warning on line 258 in src/fastcs_eiger/eiger_controller.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/fastcs_eiger/eiger_controller.py#L257-L258

Added lines #L257 - L258 were not covered by tests

Check warning on line 260 in src/fastcs_eiger/eiger_controller.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/fastcs_eiger/eiger_controller.py#L260

Added line #L260 was not covered by tests

Check warning on line 263 in src/fastcs_eiger/eiger_controller.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/fastcs_eiger/eiger_controller.py#L263

Added line #L263 was not covered by tests

Check warning on line 395 in src/fastcs_eiger/eiger_controller.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/fastcs_eiger/eiger_controller.py#L392-L395

Added lines #L392 - L395 were not covered by tests

Check warning on line 401 in src/fastcs_eiger/eiger_controller.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/fastcs_eiger/eiger_controller.py#L400-L401

Added lines #L400 - L401 were not covered by tests