Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Wagtail installation instructions #163

Merged
merged 19 commits into from
May 10, 2024

Conversation

amakarudze
Copy link
Contributor

Changes in this PR

  • Add Wagtail to Tutorial Extensions

@amakarudze amakarudze marked this pull request as draft July 28, 2023 11:19
@amakarudze amakarudze linked an issue Jul 28, 2023 that may be closed by this pull request
@amakarudze amakarudze marked this pull request as ready for review August 24, 2023 22:23
Copy link
Member

@thibaudcolas thibaudcolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it @amakarudze 😸 I think you did a great job at producing something where people can see the potential of Wagtail without it being super long.

Aside from my comments, I’d suggest to:

  • Make sure there’s no further changes needed to push this to PythonAnywhere? I’m surprised it’d all "just work" there, but maybe it’s me.
  • Update how the blog posts are fetched to only show live blog pages, and show them ordered by date.

And as quick wins that aren’t really needed but would be cool to demo:

  • Adding the Wagtail userbar. Nice little feature.
  • Perhaps making use of parent_page_types or subpage_types. This helps people understand the "child" pages quite a bit.

As a follow-up after this is merged, I’d love to know what you think of adding even more sections.

en/add_wagtail_to_your_website/README.md Outdated Show resolved Hide resolved
en/add_wagtail_to_your_website/README.md Outdated Show resolved Hide resolved
en/add_wagtail_to_your_website/README.md Outdated Show resolved Hide resolved
en/add_wagtail_to_your_website/README.md Outdated Show resolved Hide resolved
en/add_wagtail_to_your_website/install_wagtail/README.md Outdated Show resolved Hide resolved
Copy link
Member

@thibaudcolas thibaudcolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it @amakarudze 😸 I think you did a great job at producing something where people can see the potential of Wagtail without it being super long.

Aside from my comments, I’d suggest to:

  • Make sure there’s no further changes needed to push this to PythonAnywhere? I’m surprised it’d all "just work" there, but maybe it’s me.
  • Update how the blog posts are fetched to only show live blog pages, and show them ordered by date.

And as quick wins that aren’t really needed but would be cool to demo:

  • Adding the Wagtail userbar. Nice little feature.
  • Perhaps making use of parent_page_types or subpage_types. This helps people understand the "child" pages quite a bit.

As a follow-up after this is merged, I’d love to know what you think of adding even more sections.

amakarudze and others added 7 commits October 26, 2023 09:37
Co-authored-by: Thibaud Colas <thibaudcolas@gmail.com>
Co-authored-by: Thibaud Colas <thibaudcolas@gmail.com>
Co-authored-by: Thibaud Colas <thibaudcolas@gmail.com>
Co-authored-by: Thibaud Colas <thibaudcolas@gmail.com>
@amakarudze
Copy link
Contributor Author

Love it @amakarudze 😸 I think you did a great job at producing something where people can see the potential of Wagtail without it being super long.

Aside from my comments, I’d suggest to:

  • Make sure there’s no further changes needed to push this to PythonAnywhere? I’m surprised it’d all "just work" there, but maybe it’s me.
  • Update how the blog posts are fetched to only show live blog pages, and show them ordered by date.

And as quick wins that aren’t really needed but would be cool to demo:

  • Adding the Wagtail userbar. Nice little feature.
  • Perhaps making use of parent_page_types or subpage_types. This helps people understand the "child" pages quite a bit.

As a follow-up after this is merged, I’d love to know what you think of adding even more sections.

@thibaudcolas I addressed most of these points except for the quick wins that aren't really needed. They could be added later on as follow up.

@thibaudcolas
Copy link
Member

🤘I’ll do my best to review this soon

@thibaudcolas
Copy link
Member

Tagging @shyusu4 who has expressed an interest in reviewing this as part of her learning experience with Django & Wagtail 😌

Copy link
Contributor

@shyusu4 shyusu4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work and thank you for this! I think it’ll be really helpful for folks to get a headstart with how to use Wagtail CMS :)
I added a few comments and have an extra suggestion: I think it would be helpful if you added a reminder at the beginning to run python manage.py runserver, run migrations and create a superuser for Wagtail admin login so that people know how to get the project running - or so that it's clear that to run the project you need to follow some of the same steps as in the main tutorial.

en/add_wagtail_to_your_website/install_wagtail/README.md Outdated Show resolved Hide resolved
en/add_wagtail_to_your_website/install_wagtail/README.md Outdated Show resolved Hide resolved
en/add_wagtail_to_your_website/install_wagtail/README.md Outdated Show resolved Hide resolved
en/add_wagtail_to_your_website/install_wagtail/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My view of this page with wagtail version 5.2.1
Screenshot of the Wagtail CMS edit root page

@thibaudcolas
Copy link
Member

Thank you for giving this a go @shyusu4 😌 I’m still planning to review this myself too (but have to find the time somehow…)

cc my colleague @Morsey187 who is also interested in helping with reviewing this 🚀

amakarudze and others added 6 commits May 11, 2024 00:19
@amakarudze amakarudze merged commit a2bff42 into DjangoGirls:master May 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: add a tutorial extension based on Wagtail
3 participants