Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Wagtail installation instructions #163
Add Wagtail installation instructions #163
Changes from 11 commits
0acae39
3d76216
2920a27
0828b4c
bceff4a
4e7b3c9
a3e94ec
be0c1ee
1003a98
9929223
529b6c6
59e2ecb
54dd917
d69c843
955dcb1
a03afb3
c5546b2
d392bfc
bf9466c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn’t there be a specific (LTS) version specified here? Our Wagtail 5.2 LTS is due for release on November 1st so might be a good one to use. It’ll be supported until 2024-11-01.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can confirm this will break at some point, as Wagtail 6.0 due for release in February 2024 will drop Django 3.2 compatibility. So for now I’d recommend:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like to do the installation this way around in some respect, but shouldn’t this be aligned with the main tutorial and:
wagtail>=5.2,<5.3
inrequirements.txt
I’m happy either way but thought I’d check. Aside from the steps, the main difference in results is that the
pip freeze
locks all dependency versions, not just Wagtail.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is only needed if we want to use Wagtail’s redirects, which is an optional feature. It’s a really useful feature so seems fair to me we’d install it from the get-go, but I think the instructions should acknowledge it’s optional / specific to redirects.
Or – remove the extra middleware (and redirects from the INSTALLED_APPS) for the sake of simplicity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think worth clarifying that it’s common for Wagtail to be used as a "catch-all", so "all URLs except those defined to be served with something else".