Fix bug with `--exclude-default-fragments` #4

DomAyre · 2025-09-19T18:09:40Z

NOTE: Must merge after #3

Why

After #3 we found a bug where --exclude-default-fragments was broken and ignored. This PR fixes it

How

The code that uses exclude_default_fragments sets it to False for each container group regardless of the value passed in, make it a local variable instead and initialise it to the value passed in.
Update the expected rego policies

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
My extension version conforms to the Extension version schema

* add pester tests for connectedk8s cli extension * Pass the force delete param to the API call (#4) * forcedelete * format * add code owner * mypy * fix CI testcases for nodepool image issues (#8) * update errors for the config and connectivity issues (Azure#11) * update errors * format * style * update python version to 3.13 (Azure#12) * changes to support gateway association/disassociation for api version '2025-08-01-preview' (Azure#17) * update release notes and version for connectedk8s cli extension (Azure#18) * remove redundant test files specific to forked repo CI checks --------- Co-authored-by: Bavneet Singh <bavneetsingh@microsoft.com> Co-authored-by: Atchut Kumar Barli <atchut@gmail.com>

) * new version of networkcloud cli * updating min version * pushing some updates * fix run command for storage appliance on windows * update history --------- Co-authored-by: Nafiz Haider <nafizhaider@microsoft.com>

Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/msazure/One/_build/results?buildId=137934227&view=results Last commit: Azure@2105ee9

… for az aks nodepool add and az aks nodepool update (Azure#9147)

Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/msazure/One/_build/results?buildId=137942863&view=results Last commit: Azure@ce952e4

…e this extension was released. Remove incompatibility with previous CLI core version. (Azure#9200)

Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/msazure/One/_build/results?buildId=137945712&view=results Last commit: Azure@fe864e4

…re#9178)

Co-authored-by: Melody Zhu <melodyyzhu@users.noreply.github.com>

…_provider_addon_and_keyvault_id` (Azure#9221)

Simplified the aks-mcp parameter by removing custom positive/negative labels and using the default three_state_flag behavior to properly handle true/false values.

* [AKS Agent] Bump aks-mcp version to v0.0.9 * [AKS Agent] Bump aks-agent version to 1.0.0b4

Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/msazure/One/_build/results?buildId=138354998&view=results Last commit: Azure@fa62bf3

…w clearing the values (Azure#9216) * updating nexusidentity - Resolves installation issue caused by Graphs Python SDK package where a long path error occured. To fix this - SDK support was removed and replaced with httpclient * fixing a small security concern with shell * retrigger checks * retrigger checks * removing unsupported operation * removing unsupported operation * Retrigger GitHub Actions * Adding nullable to all ARM-ID fields * Adding nullable to all ARM-ID fields * fixing versioning

* migrate to aaz, support with Azure Function * remove cf, run live test * update version

Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/msazure/One/_build/results?buildId=138359475&view=results Last commit: Azure@2453de1

Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/msazure/One/_build/results?buildId=138359965&view=results Last commit: Azure@ef3c612

* Add tests for acipolicygen on arm template * Add missing sha based references * Remove helper script * Add a test for fragments * Skip test with known issue * Skip exclude default fragment tests for known issue * Update missed rego policies * Fix the curdir of acipolicygen test runner

* Bump the infra fragment minimum svn to 4 * Bump version

Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/msazure/One/_build/results?buildId=138363679&view=results Last commit: Azure@f4f6815

…r -storage behavior and add --container-storage-version (Azure#9138)

Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/msazure/One/_build/results?buildId=138547011&view=results Last commit: Azure@737b240

….extractall() on `nfd build` command (Azure#9234) * AOSM CLI - Fixing a zip-slip security bug for code that was using tar.extractall() on `nfd build` command * fixing tests * fixing tests * review updates --------- Co-authored-by: Daniel Steven <danielsteven@microsoft.com>

Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/msazure/One/_build/results?buildId=138548638&view=results Last commit: Azure@966e8d8

* Workload orchestration 3.1.0 * Update version * Update version * Adding example * Adding example * Removing pem files * Updating api version * Fixing tests * Fixing tests * Backward Compatible --------- Co-authored-by: Atharva <audapure@microsoft.com>

…0.0 ] Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/msazure/One/_build/results?buildId=138573512&view=results Last commit: Azure@d378651

…9241)

DomAyre · 2025-09-29T12:27:23Z

Moved to Azure#9248

* add pester tests for connectedk8s cli extension * Pass the force delete param to the API call (#4) * forcedelete * format * add code owner * mypy * fix CI testcases for nodepool image issues (#8) * update python version to 3.13 (Azure#12) * changes to support gateway association/disassociation for api version '2025-08-01-preview' (Azure#17) * [Azure RBAC] Deprecate 3P mode flags, fix Azure RBAC enablement bug, add E2E coverage and improve logging (Azure#20) * add pester tests for connectedk8s cli extension * Pass the force delete param to the API call (#4) * forcedelete * format * add code owner * mypy * Parameterize for airgapped clouds (#5) * Add parameterization for the airgapped clouds * Fix azdev style * MCR path function * azdev, ruff, and mypy --------- Co-authored-by: Matthew McNeal (from Dev Box) <mmcneal@microsoft.com> * Oras client fix to work with different MCRs (#6) Co-authored-by: mmcneal <mmcneal@microsoft.com> * fix CI testcases for nodepool image issues (#8) * update errors for the config and connectivity issues (Azure#11) * update errors * format * style * update python version to 3.13 (Azure#12) * Update cluster diagnostics image to 1.29.3 (#7) * Update cluster diagnostics helm chart to 1.29.3 * Fix lint issues --------- Co-authored-by: bgriddaluru <bharath.griddaluru@microsoft.com> * RBAC deprecation & fix the issue * typo * fix comments * update tests * add pester tests for connectedk8s cli extension * Pass the force delete param to the API call (#4) * forcedelete * format * add code owner * mypy * fix CI testcases for nodepool image issues (#8) * update errors for the config and connectivity issues (Azure#11) * update errors * format * style * update python version to 3.13 (Azure#12) * rebase * fix tests * fix version * fix mypy, lint * fix test * fix test * fix test * fix test * fix test * rename test * deprecate flags * rebase * rebase * bump version for release --------- Co-authored-by: Bavneet Singh <bavneetsingh@microsoft.com> Co-authored-by: Atchut Kumar Barli <atchut@gmail.com> Co-authored-by: mcnealm13 <57726243+mcnealm13@users.noreply.github.com> Co-authored-by: Matthew McNeal (from Dev Box) <mmcneal@microsoft.com> Co-authored-by: Bavneet Singh <33008256+bavneetsingh16@users.noreply.github.com> Co-authored-by: bgriddaluru <117554445+bgriddaluru@users.noreply.github.com> Co-authored-by: bgriddaluru <bharath.griddaluru@microsoft.com> Co-authored-by: vithumma <vithumma@microsoft.com> * remove redundant test files --------- Co-authored-by: Bavneet Singh <bavneetsingh@microsoft.com> Co-authored-by: Atchut Kumar Barli <atchut@gmail.com> Co-authored-by: Vineeth Thumma <vineeth-thumma@users.noreply.github.com> Co-authored-by: mcnealm13 <57726243+mcnealm13@users.noreply.github.com> Co-authored-by: Matthew McNeal (from Dev Box) <mmcneal@microsoft.com> Co-authored-by: bgriddaluru <117554445+bgriddaluru@users.noreply.github.com> Co-authored-by: bgriddaluru <bharath.griddaluru@microsoft.com> Co-authored-by: vithumma <vithumma@microsoft.com>

* add pester tests for connectedk8s cli extension * Pass the force delete param to the API call (#4) * forcedelete * format * add code owner * mypy * fix CI testcases for nodepool image issues (#8) * update python version to 3.13 (Azure#12) * changes to support gateway association/disassociation for api version '2025-08-01-preview' (Azure#17) * [Azure RBAC] Deprecate 3P mode flags, fix Azure RBAC enablement bug, add E2E coverage and improve logging (Azure#20) * add pester tests for connectedk8s cli extension * Pass the force delete param to the API call (#4) * forcedelete * format * add code owner * mypy * Parameterize for airgapped clouds (#5) * Add parameterization for the airgapped clouds * Fix azdev style * MCR path function * azdev, ruff, and mypy --------- Co-authored-by: Matthew McNeal (from Dev Box) <mmcneal@microsoft.com> * Oras client fix to work with different MCRs (#6) Co-authored-by: mmcneal <mmcneal@microsoft.com> * fix CI testcases for nodepool image issues (#8) * update errors for the config and connectivity issues (Azure#11) * update errors * format * style * update python version to 3.13 (Azure#12) * Update cluster diagnostics image to 1.29.3 (#7) * Update cluster diagnostics helm chart to 1.29.3 * Fix lint issues --------- Co-authored-by: bgriddaluru <bharath.griddaluru@microsoft.com> * RBAC deprecation & fix the issue * typo * fix comments * update tests * add pester tests for connectedk8s cli extension * Pass the force delete param to the API call (#4) * forcedelete * format * add code owner * mypy * fix CI testcases for nodepool image issues (#8) * update errors for the config and connectivity issues (Azure#11) * update errors * format * style * update python version to 3.13 (Azure#12) * rebase * fix tests * fix version * fix mypy, lint * fix test * fix test * fix test * fix test * fix test * rename test * deprecate flags * rebase * rebase * bump version for release --------- Co-authored-by: Bavneet Singh <bavneetsingh@microsoft.com> Co-authored-by: Atchut Kumar Barli <atchut@gmail.com> Co-authored-by: mcnealm13 <57726243+mcnealm13@users.noreply.github.com> Co-authored-by: Matthew McNeal (from Dev Box) <mmcneal@microsoft.com> Co-authored-by: Bavneet Singh <33008256+bavneetsingh16@users.noreply.github.com> Co-authored-by: bgriddaluru <117554445+bgriddaluru@users.noreply.github.com> Co-authored-by: bgriddaluru <bharath.griddaluru@microsoft.com> Co-authored-by: vithumma <vithumma@microsoft.com> * remove hardcoded public ARM endpoint url for fairfax and mooncake (Azure#24) * Bug Fix for FFX mcr url (Azure#22) * [connectedk8s] update release notes and version (Azure#26) * remove redundant test files * remove change not relevant to connectedk8s release --------- Co-authored-by: Bavneet Singh <bavneetsingh@microsoft.com> Co-authored-by: Atchut Kumar Barli <atchut@gmail.com> Co-authored-by: Vineeth Thumma <vineeth-thumma@users.noreply.github.com> Co-authored-by: mcnealm13 <57726243+mcnealm13@users.noreply.github.com> Co-authored-by: Matthew McNeal (from Dev Box) <mmcneal@microsoft.com> Co-authored-by: bgriddaluru <117554445+bgriddaluru@users.noreply.github.com> Co-authored-by: bgriddaluru <bharath.griddaluru@microsoft.com> Co-authored-by: vithumma <vithumma@microsoft.com> Co-authored-by: hapate <hapate@microsoft.com>

DomAyre force-pushed the fix-exclude-default-fragments branch from 1f39946 to 25677b6 Compare September 20, 2025 16:07

DomAyre mentioned this pull request Sep 20, 2025

Define a clear format for ACI policy specification #6

Closed

9 tasks

DomAyre force-pushed the test-arm-files branch from 2759049 to 667b777 Compare September 22, 2025 09:22

DomAyre mentioned this pull request Sep 22, 2025

[confcom] Add tests for acipolicygen Azure/azure-cli-extensions#9199

Merged

6 tasks

nafizhaider32 and others added 7 commits September 23, 2025 11:01

[Release] Update index.json for extension [ networkcloud-4.0.0b1 ]

373f715

Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/msazure/One/_build/results?buildId=137934227&view=results Last commit: Azure@2105ee9

[AKS] Add option AzureLinuxOSGuard and AzureLinux3OSGuard to --os-sku…

ce952e4

… for az aks nodepool add and az aks nodepool update (Azure#9147)

[Release] Update index.json for extension [ aks-preview-18.0.0b39 ]

6902ac5

Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/msazure/One/_build/results?buildId=137942863&view=results Last commit: Azure@ce952e4

{Zones} Pin minCliCoreVersion 2.72.0 as the latest CLI version befor…

fe864e4

…e this extension was released. Remove incompatibility with previous CLI core version. (Azure#9200)

[Release] Update index.json for extension [ zones-1.0.0b5 ]

2e44d16

Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/msazure/One/_build/results?buildId=137945712&view=results Last commit: Azure@fe864e4

exclude tests folder (Azure#9213)

c54b7ce

DomAyre force-pushed the fix-exclude-default-fragments branch 2 times, most recently from b14d692 to e7c8027 Compare September 23, 2025 15:47

vilit1 and others added 2 commits September 24, 2025 10:06

new release (Azure#9218)

f7dcb34

[AKS] Add option Windows2025 to --os-sku for az aks nodepool add (Azu…

3e71b78

…re#9178)

DomAyre force-pushed the fix-exclude-default-fragments branch from e7c8027 to 7b92e93 Compare September 24, 2025 18:38

melodyyzhu and others added 12 commits September 25, 2025 10:56

arcdata version bump to 1.5.26 (Azure#9148)

9c55a47

Co-authored-by: Melody Zhu <melodyyzhu@users.noreply.github.com>

{AKS} Fix test case `test_aks_approuting_enable_with_keyvault_secrets…

b0179e3

…_provider_addon_and_keyvault_id` (Azure#9221)

[AKS] Fix --aks-mcp flag to accept true/false values (Azure#9231)

53d2d0a

Simplified the aks-mcp parameter by removing custom positive/negative labels and using the default three_state_flag behavior to properly handle true/false values.

[AKS Agent] Bump aks-mcp version to v0.0.9 (Azure#9236)

fa62bf3

* [AKS Agent] Bump aks-mcp version to v0.0.9 * [AKS Agent] Bump aks-agent version to 1.0.0b4

[Release] Update index.json for extension [ aks-agent-1.0.0b4 ]

447da6d

Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/msazure/One/_build/results?buildId=138354998&view=results Last commit: Azure@fa62bf3

{stream-analytics} Support with Azure Function (Azure#9179)

ef3c612

* migrate to aaz, support with Azure Function * remove cf, run live test * update version

[Release] Update index.json for extension [ managednetworkfabric-8.2.0 ]

b037b44

Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/msazure/One/_build/results?buildId=138359475&view=results Last commit: Azure@2453de1

[Release] Update index.json for extension [ stream-analytics-1.0.1 ]

d807729

Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/msazure/One/_build/results?buildId=138359965&view=results Last commit: Azure@ef3c612

[confcom] Bump the infra fragment minimum svn to 4 (Azure#9238)

f4f6815

* Bump the infra fragment minimum svn to 4 * Bump version

[Release] Update index.json for extension [ confcom ]

128dd90

Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/msazure/One/_build/results?buildId=138363679&view=results Last commit: Azure@f4f6815

DomAyre force-pushed the fix-exclude-default-fragments branch from 7b92e93 to 9c0f192 Compare September 27, 2025 13:04

nearora-msft and others added 12 commits September 29, 2025 11:33

AKS: Change --enable-azure-container-storage --disable-azure-containe…

737b240

…r -storage behavior and add --container-storage-version (Azure#9138)

[Release] Update index.json for extension [ aks-preview-18.0.0b40 ]

dcfe66b

Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/msazure/One/_build/results?buildId=138547011&view=results Last commit: Azure@737b240

[Release] Update index.json for extension [ aosm-2.0.0b3 ]

dfd42d4

Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/msazure/One/_build/results?buildId=138548638&view=results Last commit: Azure@966e8d8

Skip none overrides on localdns profile (Azure#9188)

032b5e2

Add JWT Authenticator commands to aks-preview (Azure#9189)

fbb4437

[Release] Update index.json for extension [ workload-orchestration-4.…

f3abba6

…0.0 ] Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/msazure/One/_build/results?buildId=138573512&view=results Last commit: Azure@d378651

Fix merge conflict between new tests and default min svn bump (Azure#…

d3a1ab5

…9241)

Fix bug with --exclude-default-fragments

06776dc

Satisfy azdev style

9dcb7fd

Bump the version

9d386e2

DomAyre force-pushed the fix-exclude-default-fragments branch from d772a9d to 9d386e2 Compare September 29, 2025 12:12

DomAyre closed this Sep 29, 2025

DomAyre mentioned this pull request Oct 1, 2025

[confcom] Define the format for ACI policy specifications Azure/azure-cli-extensions#9262

Open

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix bug with `--exclude-default-fragments` #4

Fix bug with `--exclude-default-fragments` #4

Uh oh!

DomAyre commented Sep 19, 2025

Uh oh!

DomAyre commented Sep 29, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

18 participants

Fix bug with --exclude-default-fragments #4

Fix bug with --exclude-default-fragments #4

Uh oh!

Conversation

DomAyre commented Sep 19, 2025

Why

How

Related command

General Guidelines

Uh oh!

DomAyre commented Sep 29, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

18 participants

Fix bug with `--exclude-default-fragments` #4

Fix bug with `--exclude-default-fragments` #4