Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for omega sphere transport tests #262

Merged
merged 7 commits into from
Jan 23, 2025

Conversation

cbegeman
Copy link
Collaborator

Add omega support for the sphere_transport test suite

Checklist

  • Testing comment in the PR documents testing used to verify the changes

@cbegeman
Copy link
Collaborator Author

cbegeman commented Jan 17, 2025

Testing

Test suite has been run on chrysalis, intel-impi with omega. All tests fail because they do not meet the order of convergence.

rotation_2d has 1st order convergence
correlated_tracers_2d, divergent_2d and nondivergent_2d do not converge

I tried reducing the time step by a factor of 2 and it did not affect convergence rates.

@cbegeman cbegeman added in progress This PR is not ready for review or merging ocean Related to ocean tests or analysis labels Jan 17, 2025
@xylar
Copy link
Collaborator

xylar commented Jan 18, 2025

@cbegeman, could you post images of the beginning and end states at the highest resolution? It could really be that the centered advection we currently have is not convergent for these more rigorous tracer tests with small-scale tracer or velocity-field structure.

This, in turn, would point to the urgency of higher-order tracer advection that we discussed on Monday.

@cbegeman
Copy link
Collaborator Author

This test suite appears to be performing appropriately for Omega.

rotation_2d is the case that is closest to the cosine_bell test case; cosine bell tracer distribution and a rotational field. It has convergence of 1.685 whereas the cosine_bell case has convergence of 1.364. For MPAS-Ocean with 2nd order advection, the rotation_2d case has convergence of 1.711 and the cosine_bell case has convergence of 1.364.

tracer2_init
tracer2_final
tracer2_diff

@xylar
Copy link
Collaborator

xylar commented Jan 22, 2025

Thanks @cbegeman. This looks good to me. The code also looks good. Let me know when you think this is ready for review.

@cbegeman cbegeman removed the in progress This PR is not ready for review or merging label Jan 22, 2025
@cbegeman cbegeman marked this pull request as ready for review January 22, 2025 21:21
@cbegeman cbegeman requested a review from xylar January 22, 2025 21:21
Copy link
Collaborator

@xylar xylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cbegeman, this looks excellent! Thanks for taking the time to work on this.

I was able to run all 8 tests (icos and qu, all 4 test types) as well as the viz for icos/rotation_2d (I didn't try the other 7 viz cases) on Chyrsalis with Omega from the current develop branch.

I took a look at the viz output and it's pretty clear why convergence is poor -- the oscillations that you showed above at 60 km are much worse for both coarser resolutions and for tracer3 (the slotted cylinder). e.g.:

tracer3_final

@cbegeman
Copy link
Collaborator Author

Yes. I ran MPAS-Ocean with centered tracer advection and the behavior is similar.

@cbegeman
Copy link
Collaborator Author

@xylar Thanks for reviewing!

@cbegeman cbegeman merged commit b5930ee into E3SM-Project:main Jan 23, 2025
5 checks passed
@xylar xylar deleted the add-omega-sphere-transport branch January 24, 2025 13:41
xylar added a commit to xylar/polaris that referenced this pull request Jan 24, 2025
This was being turned off elsewhere until E3SM-Project#262 for single-layer
tests (which this one is by default) but should be turned off
by default.
@xylar xylar mentioned this pull request Jan 24, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ocean Related to ocean tests or analysis
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants