-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for omega sphere transport tests #262
Add support for omega sphere transport tests #262
Conversation
TestingTest suite has been run on chrysalis, intel-impi with omega. All tests fail because they do not meet the order of convergence.
I tried reducing the time step by a factor of 2 and it did not affect convergence rates. |
@cbegeman, could you post images of the beginning and end states at the highest resolution? It could really be that the centered advection we currently have is not convergent for these more rigorous tracer tests with small-scale tracer or velocity-field structure. This, in turn, would point to the urgency of higher-order tracer advection that we discussed on Monday. |
This test suite appears to be performing appropriately for Omega.
|
Thanks @cbegeman. This looks good to me. The code also looks good. Let me know when you think this is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cbegeman, this looks excellent! Thanks for taking the time to work on this.
I was able to run all 8 tests (icos and qu, all 4 test types) as well as the viz for icos/rotation_2d (I didn't try the other 7 viz cases) on Chyrsalis with Omega from the current develop
branch.
I took a look at the viz output and it's pretty clear why convergence is poor -- the oscillations that you showed above at 60 km are much worse for both coarser resolutions and for tracer3 (the slotted cylinder). e.g.:
Yes. I ran MPAS-Ocean with centered tracer advection and the behavior is similar. |
@xylar Thanks for reviewing! |
This was being turned off elsewhere until E3SM-Project#262 for single-layer tests (which this one is by default) but should be turned off by default.
Add omega support for the
sphere_transport
test suiteChecklist
Testing
comment in the PR documents testing used to verify the changes