Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ctsm5.3.025: Update default FATES parameter file to API 37.1 #2965

Merged
merged 6 commits into from
Feb 20, 2025

Conversation

glemieux
Copy link
Collaborator

@glemieux glemieux commented Feb 14, 2025

Description of changes

This simple PR updates the default fates parameter file as well as the fates tag.

Specific notes

This parameter file should be coordinated with NGEET/fates#1334 fates pull request.

To do:

  • add new default parameter file to svn server
  • update fates submodule commit hash to associated fates tag

Contributors other than yourself, if any:

CTSM Issues Fixed (include github issue #):

Are answers expected to change (and if so in what way)?

Any User Interface Changes (namelist or namelist defaults changes)?

Does this create a need to change or add documentation? Did you do so?

Testing performed, if any: regular fates

@glemieux glemieux changed the title Update default FATES parameter file to API.37.1 Update default FATES parameter file to API 37.1 Feb 14, 2025
@glemieux glemieux marked this pull request as ready for review February 14, 2025 23:40
@glemieux glemieux changed the title Update default FATES parameter file to API 37.1 ctsm5.3.025: Update default FATES parameter file to API 37.1 Feb 14, 2025
@glemieux glemieux requested a review from slevis-lmwg February 14, 2025 23:40
Copy link
Contributor

@slevis-lmwg slevis-lmwg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very simple, as stated in the PR description. Thanks @glemieux!

@samsrabin samsrabin added test: aux_clm Pass aux_clm suite before merging test: fates Pass fates test suite before merging labels Feb 16, 2025
@glemieux
Copy link
Collaborator Author

Regression testing on derecho is underway.

@glemieux
Copy link
Collaborator Author

FYI, @rgknox caught an error on the fates side so I'm rerunning the tests.

@glemieux
Copy link
Collaborator Author

Fates testing is complete on derecho and izumi and NGEET/fates#1334 has been merged and tagged. The FATES tag has been updated here and aux_clm testing is underway.

@glemieux
Copy link
Collaborator Author

All expected aux_clm tests are passing on derecho. All non-fates tests are B4B against ctsm5.3.024 as expected as well.

Results: /glade/u/home/glemieux/ctsm/tests_0218-160033de

@glemieux
Copy link
Collaborator Author

glemieux commented Feb 19, 2025

Nearly all aux_clm tests in izumi are complete. I had to resubmit two tests that failed MODEL_BUILD immediately:

FAIL ERP_D_Ld9.f10_f10_mg37.I1850Clm60BgcCrop.izumi_nag.clm-clm60cam7LndTuningModeLDust MODEL_BUILD time=1
FAIL ERP_D_P48x1.f10_f10_mg37.IHistClm60Bgc.izumi_nag.clm-decStart MODEL_BUILD time=1

The decStart test passed upon rebuild and resubmission and is B4B against ctsm5.3.025. The other test passed MODEL_BUILD, but failed RUN due to #2800, which we've seen before with this specific test. I'm resubmitting it again.

All other non-FATES tests are B4B.

Results: /scratch/cluster/glemieux/ctsm-tests/tests_0218-160638iz

UPDATE: clm60cam7LndTuningModeLDust passed B4B against ctsm5.3.024 upon resubmission.

@ekluzek ekluzek merged commit dfc19aa into ESCOMP:master Feb 20, 2025
2 checks passed
@ekluzek ekluzek deleted the fates-api37.1 branch February 20, 2025 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test: aux_clm Pass aux_clm suite before merging test: fates Pass fates test suite before merging
Projects
Status: Done (non release/external)
Status: Todo
Development

Successfully merging this pull request may close these issues.

5 participants