API 37.1 parameter file merge #1334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug fix for issue NGEET#1301 Corrects when the fraction of burnt fuel is zero'd and how the litter mass is updated based on that fraction.
CamelCase! (camels are grazers too) Co-authored-by: Gregory Lemieux <7565064+glemieux@users.noreply.github.com>
This minor formatting update is after running the patch parameter file through UpdateParamAPI.py
ordering restore using ncvarsort from sci.1.80.4_api.37.0.0
…nto api37.1-parameter-merge
include the pr number for better traceability
|
To do:
|
This was referenced Feb 14, 2025
PR NGEET#1262 will be incorporated at a later date, but we are adding the parameters to the default here to coincide with a minor API update.
Removing the date strings from the patch files as I think it doesn't really add anything to help the user. I also update the base file in multiple xml files to use the fates_params_default.cdl so as to build on the previous xml files included in this pull request.
This updates the CDL with the associated new variables as well
This instructs the user on how best to apply the patches
This was processed using the pr1262 patch file update
This was referenced Feb 18, 2025
Merged
|
Regression testing on Results: Still waiting on fates suite testing on |
rgknox
approved these changes
Feb 18, 2025
|
Regression testing on Results: |
glemieux
added a commit
to glemieux/fates
that referenced
this pull request
Feb 20, 2025
The variable additions were incorporated via NGEET#1334
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This pull request merges in #1263 and #1319, which are exclusively parameter file updates, as well as #1140, which has both parameter file and feature updates, as a single merge commit that will be given one fates tag. This will also pull in the parameter file additions for #1262 in preparation for that PR coming in at a later date.
This should be coordinated with ESCOMP/CTSM#2965
Collaborators:
Expectation of Answer Changes:
Yes, consistent with answer changes due to #1140, #1263, and #1319
Checklist
If this is your first time contributing, please read the CONTRIBUTING document.
All checklist items must be checked to enable merging this pull request:
Contributor
Integrator
Documentation
Test Results:
CTSM (or) E3SM (specify which) test hash-tag:
CTSM (or) E3SM (specify which) baseline hash-tag:
FATES baseline hash-tag:
Test Output: