Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fee discount update #459

Merged
merged 3 commits into from
Sep 26, 2024
Merged

Fee discount update #459

merged 3 commits into from
Sep 26, 2024

Conversation

jgriffiths
Copy link
Contributor

As reported to and fixed in Elements upstream (ElementsProject/elements#1366), the amount and nonce commitments must be counted as base weight, not witness weight.

…timization

The compiler incorrectly infers these warnings when optimization is not
enabled. Add initializers to silence them so debug builds are clean.
As reported to and fixed in Elements upstream, the amount and nonce
commitments must be counted as base weight, not witness weight.

This makes blinded and unblinded standard txs the same size with the
discount applied.
@jgriffiths jgriffiths merged commit 89e8f8f into master Sep 26, 2024
5 checks passed
@jgriffiths jgriffiths deleted the fee_discount_update branch September 26, 2024 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant