Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fee discount update #459

Merged
merged 3 commits into from
Sep 26, 2024
Merged

Fee discount update #459

merged 3 commits into from
Sep 26, 2024

Commits on Sep 25, 2024

  1. build: remove spurious warning when compiling debug builds without op… 

    …timization

The compiler incorrectly infers these warnings when optimization is not
enabled. Add initializers to silence them so debug builds are clean.
    @jgriffiths
    jgriffiths committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    1103266 View commit details
    Browse the repository at this point in the history

  2. script: clarify that weight calculation includes the field prefix

    @jgriffiths
    jgriffiths committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    493c8bd View commit details
    Browse the repository at this point in the history

  3. tx: update the elements transaction discount calculation 

    As reported to and fixed in Elements upstream, the amount and nonce
commitments must be counted as base weight, not witness weight.

This makes blinded and unblinded standard txs the same size with the
discount applied.
    @jgriffiths
    jgriffiths committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    89e8f8f View commit details
    Browse the repository at this point in the history