-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix VS CMake generator finder #30
fix: fix VS CMake generator finder #30
Conversation
Co-Authored-By: Dief Bell <107551242+diefbell-grabcad@users.noreply.github.com>
8fdb172
to
1f9c204
Compare
…-grabcad/cmake-ts into fix-vs-generator-finder
I had rebased this into a single commit. Any reason to undo that? Could you rebase and squash the changes? |
package.json
Outdated
@@ -1,6 +1,6 @@ | |||
{ | |||
"name": "cmake-ts", | |||
"version": "0.3.0", | |||
"version": "0.4.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please keep the version as is. We can publish it as a patch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So bump patch version? Or just leave as is?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leave as is. I'll handle the version bunp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
I have no idea how that happened. I can try just creating a new branch. I think because my branch was off your fork originally. |
Sounds good. Here's the branch I rebased: |
Created #32 without messy un-squash |
If a newer version of Visual Studio build tools (>= 2019) is installed then the automatic build tools finder fails because
cmake -G
outputs:and the function
GET_CMAKE_VS_GENERATOR
doesn't recognise them because it expects the[arch]
suffix.This fixes:
- Above issue;
- Issue where one of the build tools is prefixed by
*
(I think that means it's the system default or something? Idk;)- For the build tools that don't end with
[arch]
, it appends-A arch
to the generator string in the argumentBuilder (kinda janky).