-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix VS CMake generator finder #30
Closed
diefbell-grabcad
wants to merge
21
commits into
EmbeddedEnterprises:master
from
diefbell-grabcad:fix-vs-generator-finder
Closed
Changes from 20 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
61fd23d
chore: publish as @aminya/cmake-ts
aminya 953d447
fix: replace deprecated zlib with minizlib
aminya 8613514
chore(release): 0.3.0-aminya.2
aminya a63e502
fix: replace queueable with simple Promise
aminya 9f0a65f
chore(release): 0.3.0-aminya.3
aminya dca7601
fix: allow redirects when requesting
aminya 2f7f44a
chore(release): 0.3.0-aminya.4
aminya 5489bdc
fix: downgarde to which 2 for node 10 support
aminya daaf939
chore(release): 0.3.0-aminya.5
aminya 64a0498
fix: downgrade tar, npmlog, minizlib for Node 10 support
aminya bedf16f
chore(release): 0.3.0-aminya.6
aminya a663112
fix: downgrade fs-extra for node 10 support
aminya ddd5ae0
chore(release): 0.3.0-aminya.7
aminya 45397a8
Fixed some bugs with getting VS generator from `cmake -G`
diefbell-grabcad e7e2f72
Bumped version number
diefbell-grabcad cd860a9
Won't add `-A arch` argument to non-Visual Studio generators
diefbell-grabcad 3b8eeb0
Fixed condition I promise this time
diefbell-grabcad c144d18
Haven't broken older x86 builds I hope
diefbell-grabcad 1f9c204
fix: fix VS CMake generator finder
diefbell-grabcad e15b1d4
Merge branch 'fix-vs-generator-finder' of https://github.com/diefbell…
diefbell-grabcad e9e8faf
Reverted version in package.json
diefbell-grabcad File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please keep the version as is. We can publish it as a patch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So bump patch version? Or just leave as is?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leave as is. I'll handle the version bunp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done