Fix: VS CMake Generator Finder can Now Find MSVS 2019+ Automatically#32
Conversation
|
Still waiting on getting access to npm before reviewing new PRs. |
|
@aminya is this in a position to be merged yet? |
I was hoping that @martin31821 would give me access to npm so that I can publish the package. I'll try to reach out again. |
|
Would it be worth putting it into your fork and updating ZeroMQ to use that in the meantime? |
|
And chance of getting this in the @aminya / forks? This stuff might block me soon. I can reopen the PRs on there? |
|
@diefbell-grabcad I can merge it myself. I'll probably publish to aminya/cmake-ts from this repo. @martin31821 told me he had lost the 2FA keys for npm, so we're out of luck in updating the original package unless the npm support helps. |
|
Yeah that'd be great, then can PR it into zeromq 👍 |
|
@aminya I apparently can't create the PR but here's the diff https://github.com/aminya/cmake-ts/compare/aminya:master...EmbeddedEnterprises:master?expand=1 |
|
@diefbell-grabcad Good news! I finally got access to npm. I have published all the changes under |
If a newer version of Visual Studio build tools (>= 2019) is installed then the automatic build tools finder fails because
cmake -Goutputs:and the function
GET_CMAKE_VS_GENERATORdoesn't recognise them because it expects the[arch]suffix.This fixes:
- Above issue;
- Issue where one of the build tools is prefixed by
*(I think that means it's the system default or something? Idk;)- For the build tools that don't end with
[arch], it appends-A archto the generator string in the argumentBuilder (kinda janky).