Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script to create main release static content #130

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

leannehaggerty
Copy link
Member

Currently works for the creating the new general vertebrate static content, i.e. content outlined here https://docs.google.com/document/d/1oaEVACrM_J4WruJragbpNUC8h8qjUxbh6q90_FXpMuY/edit?tab=t.0#heading=h.g9et3sgf9qa7

Note:

  • This is not the agreed content for the mouse strains, the script should be updated for that

Copy link
Contributor

@ens-ftricomi ens-ftricomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is fine for me but I will leave the final approving on the metadata to Jose.
Thanks!

@EreboPSilva
Copy link
Member

Tested for cow and cat and works fine for both.

EreboPSilva
EreboPSilva previously approved these changes Nov 8, 2024
Copy link
Member

@EreboPSilva EreboPSilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@EreboPSilva
Copy link
Member

Oh, there was some talk about creating a pre-requisites.txt, so I'll delay merging until that.

@EreboPSilva
Copy link
Member

Can you take a look at the adaptation and re-approve, @leannehaggerty?
Mentioning also @ens-ftricomi for continuity.

@EreboPSilva EreboPSilva dismissed their stale review December 24, 2024 15:10

I made changes and can't review myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants