feat: add pagination support for recall search results#3
Open
feat: add pagination support for recall search results#3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Off-by-one error (_search.py:95): Uses offset = page * per_page instead of (page - 1) * per_page — page 1 returns empty results, page 2 returns what page 1 should have, etc.
page param not passed (_search.py:125): search_entity_facts accepts page but only passes per_page to find_similar_embeddings — pagination always uses default page=1 regardless of what's requested.
per_page not passed (recall.py:56): search_facts passes page to search_entity_facts but forgets per_page — pagination config is set but never applied.