Skip to content

Conversation

giordano
Copy link
Member

This allows creating traced arrays with shape different than the original data, without having to add extra reshape instructions. Ref: #1669 (comment).

This allows creating traced arrays with shape different than the original data,
without having to add extra `reshape` instructions.
Copy link

codecov bot commented Sep 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.91%. Comparing base (b39a1fc) to head (3b91d3a).
⚠️ Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1712      +/-   ##
==========================================
+ Coverage   68.16%   69.91%   +1.75%     
==========================================
  Files         109      113       +4     
  Lines       11779    12473     +694     
==========================================
+ Hits         8029     8721     +692     
- Misses       3750     3752       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wsmoses
Copy link
Member

wsmoses commented Sep 28, 2025

I'm not convinced this is the best design. It feels like it would be better to specialize fixedsizeareays to retain the shape information than to pipe through arrays for all trace overrides. Eg I'm unclear who other than fixed size arrays would need (and also am somewhat worried about the soundness of an outer array propagation into)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants