Skip to content

Allow passing custom size to Array-like make_tracer methods #1712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Allow passing custom size to Array-like make_tracer methods #1712

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions src/Tracing.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1169,6 +1169,7 @@ Base.@nospecializeinfer function make_tracer(
@nospecialize(sharding = Sharding.NoSharding()),
@nospecialize(device = nothing),
@nospecialize(client = nothing),
@nospecialize(size = size(prev)),
kwargs...,
) where {T,N}
if mode == TracedToTypes
Expand All @@ -1177,7 +1178,7 @@ Base.@nospecializeinfer function make_tracer(
mode == ArrayToConcrete && return ConcretePJRTArray(prev; sharding, device, client)
mode != ConcreteToTraced && throw("Cannot trace concrete")
haskey(seen, prev) && return seen[prev]::TracedRArray{T,N}
res = TracedRArray{T,N}((path,), nothing, size(prev))
res = TracedRArray{T,N}((path,), nothing, size)
seen[prev] = res
return res
end
Expand All @@ -1190,6 +1191,7 @@ Base.@nospecializeinfer function make_tracer(
@nospecialize(sharding = Sharding.NoSharding()),
@nospecialize(device = nothing),
@nospecialize(client = nothing),
@nospecialize(size = size(prev)),
kwargs...,
) where {T,N}
if mode == TracedToTypes
Expand All @@ -1198,7 +1200,7 @@ Base.@nospecializeinfer function make_tracer(
mode == ArrayToConcrete && return ConcreteIFRTArray(prev; sharding, device, client)
mode != ConcreteToTraced && throw("Cannot trace concrete")
haskey(seen, prev) && return seen[prev]::TracedRArray{T,N}
res = TracedRArray{T,N}((path,), nothing, size(prev))
res = TracedRArray{T,N}((path,), nothing, size)
seen[prev] = res
return res
end
Expand Down Expand Up @@ -1254,6 +1256,7 @@ Base.@nospecializeinfer function make_tracer(
tobatch=nothing,
@nospecialize(sharding = Sharding.NoSharding()),
@nospecialize(runtime = nothing),
@nospecialize(size = size(prev)),
kwargs...,
) where {T,N}
if mode == ConcreteToTraced
Expand Down Expand Up @@ -1287,7 +1290,7 @@ Base.@nospecializeinfer function make_tracer(
elseif tobatch !== nothing
error("This should not happen...")
else
TracedRArray{T,N}((path,), prev.mlir_data, size(prev))
TracedRArray{T,N}((path,), prev.mlir_data, size)
end
seen[prev] = res
return res
Expand All @@ -1298,7 +1301,7 @@ Base.@nospecializeinfer function make_tracer(
haskey(seen, prev) && return seen[prev]::ConcretePJRTArray{T,N}
if !Sharding.is_sharded(sharding)
res = ConcretePJRTArray{T,N,1,Sharding.NoShardInfo}(
(XLA.PJRT.AsyncEmptyBuffer,), size(prev), Sharding.NoShardInfo()
(XLA.PJRT.AsyncEmptyBuffer,), size, Sharding.NoShardInfo()
)
else
error("TODO: implement sharding")
Expand All @@ -1309,7 +1312,7 @@ Base.@nospecializeinfer function make_tracer(
haskey(seen, prev) && return seen[prev]::ConcreteIFRTArray{T,N}
if !Sharding.is_sharded(sharding)
res = ConcreteIFRTArray{T,N,Sharding.NoShardInfo}(
XLA.IFRT.AsyncEmptyArray, size(prev), Sharding.NoShardInfo()
XLA.IFRT.AsyncEmptyArray, size, Sharding.NoShardInfo()
)
else
error("TODO: implement sharding")
Expand Down Expand Up @@ -1556,6 +1559,7 @@ Base.@nospecializeinfer function make_tracer(
@nospecialize(runtime = nothing),
@nospecialize(device = nothing),
@nospecialize(client = nothing),
@nospecialize(size = size(prev)),
kwargs...,
)
RT = Core.Typeof(prev)
Expand Down Expand Up @@ -1604,7 +1608,7 @@ Base.@nospecializeinfer function make_tracer(
return nothing
end
TT = traced_type(eltype(RT), Val(mode), track_numbers, sharding, runtime)
newa = Array{TT,ndims(RT)}(undef, size(prev))
newa = Array{TT,ndims(RT)}(undef, size)
seen[prev] = newa
same = true
for I in eachindex(prev)
Expand Down
Loading