Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up data scraping code #30

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Clean up data scraping code #30

merged 2 commits into from
Nov 6, 2024

Conversation

apulsipher
Copy link
Collaborator

No description provided.

@apulsipher apulsipher linked an issue Nov 5, 2024 that may be closed by this pull request
@apulsipher
Copy link
Collaborator Author

@gvegayon The main point of this PR is to add error handling for downloading the file, so it won't crash our forecast website if the URL changes. I want to make sure that we're failing gracefully, but I don't know if what I've done here follows R best practices for URL access or catching errors. Please let me know!

Copy link
Collaborator

@gvegayon gvegayon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks great! Yes, tryCatch is the standard R way to do things. Thanks!

@apulsipher apulsipher merged commit 225293f into main Nov 6, 2024
3 checks passed
@apulsipher apulsipher deleted the 26-clean-data-scraper branch November 6, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up data scraping script in forecasting report
2 participants