Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated API key instructions for citra update on June 26th #580

Merged
merged 5 commits into from
Jul 5, 2024
Merged

Updated API key instructions for citra update on June 26th #580

merged 5 commits into from
Jul 5, 2024

Conversation

pMaske
Copy link
Member

@pMaske pMaske commented Jun 18, 2024

Updated API key links in toolkit samples

@pMaske pMaske requested review from dotMorten and duffh June 18, 2024 21:18
dotMorten
dotMorten reviewed Jun 18, 2024
View reviewed changes
src/Samples/Toolkit.SampleApp.Maui/MainPage.xaml.cs Outdated
}

private void MoreInfoLinkTapped(object sender, TappedEventArgs e)
{
Microsoft.Maui.ApplicationModel.Launcher.OpenAsync("https://developers.arcgis.com/net/security-and-authentication/#api-keys");
Microsoft.Maui.ApplicationModel.Launcher.OpenAsync("https://developers.arcgis.com/net/security-and-authentication/tutorials/create-an-api-key/");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this pages returns 404.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is no longer needed. Removed in my latest commit.

src/Samples/Toolkit.SampleApp.UWP/MainPage.xaml Outdated
<Span>You can get or create an API key from <Hyperlink NavigateUri="https://developers.arcgis.com/api-keys/">your developer dashboard</Hyperlink>.</Span><LineBreak></LineBreak>
<Hyperlink NavigateUri="https://developers.arcgis.com/net/security-and-authentication/#api-keys">More info on API Keys</Hyperlink>
<Span>You can get or create an API key as described in <Hyperlink NavigateUri="https://links.esri.com/create-an-api-key">this tutorial</Hyperlink>.</Span>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You removed the more-info here and below, but maui still has the more info. Which solution are we going with?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More-info is also not needed any longer. I missed to removed it from MAUI. Just updated the PR. Please review the latest commit.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as above "You can create an API Key access token as described...."

@pMaske pMaske requested a review from dotMorten June 20, 2024 22:06
maryharvey
maryharvey suggested changes Jun 20, 2024
View reviewed changes
Copy link

@maryharvey maryharvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pMaske a small suggestion. thanks

src/Samples/Toolkit.SampleApp.Maui/MainPage.xaml Outdated
@@ -36,8 +36,8 @@
<Label MaxLines="5" Margin="0,10,0,0" >
<Label.FormattedText>
<FormattedString>
<Span Text="You can get or create an API key from " />
<Span Text="your developer dashboard" TextDecorations="Underline" TextColor="{AppThemeBinding Light={StaticResource Blue100Accent}, Dark={StaticResource Blue300Accent}}" >
<Span Text="You can get or create an API key by following" />
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can create an API Key using the Create an api key Tutorial... but you cannot get/copy one after the API Key has been generated. You only get one opportunity to copy it so I would be tempted to just say "You can create an API Key access token by...."

src/Samples/Toolkit.SampleApp.UWP/MainPage.xaml Outdated
<Span>You can get or create an API key from <Hyperlink NavigateUri="https://developers.arcgis.com/api-keys/">your developer dashboard</Hyperlink>.</Span><LineBreak></LineBreak>
<Hyperlink NavigateUri="https://developers.arcgis.com/net/security-and-authentication/#api-keys">More info on API Keys</Hyperlink>
<Span>You can get or create an API key as described in <Hyperlink NavigateUri="https://links.esri.com/create-an-api-key">this tutorial</Hyperlink>.</Span>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as above "You can create an API Key access token as described...."

src/Samples/Toolkit.SampleApp.WPF/MainWindow.xaml Outdated
@@ -59,8 +59,7 @@
Click="SaveApiKey_Click"
/>
<TextBlock TextWrapping="Wrap" Margin="0,10,0,0">
<Span>You can get or create an API key from <Hyperlink NavigateUri="https://developers.arcgis.com/api-keys/" RequestNavigate="Hyperlink_RequestNavigate">your developer dashboard</Hyperlink>.</Span><LineBreak></LineBreak>
<Hyperlink NavigateUri="https://developers.arcgis.com/net/security-and-authentication/#api-keys" RequestNavigate="Hyperlink_RequestNavigate">More info on API Keys</Hyperlink>
<Span>You can get or create an API key as described in <Hyperlink NavigateUri="https://links.esri.com/create-an-api-key" RequestNavigate="Hyperlink_RequestNavigate">this tutorial</Hyperlink>.</Span>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As above "You can create an API Key access token as..."

src/Samples/Toolkit.SampleApp.WinUI/MainWindow.xaml Outdated
@@ -64,8 +64,7 @@
Background="CornflowerBlue" Foreground="White"
Click="SaveApiKey_Click" />
<TextBlock TextWrapping="Wrap" Margin="0,10,0,0">
<Span>You can get or create an API key from <Hyperlink NavigateUri="https://developers.arcgis.com/api-keys/">your developer dashboard</Hyperlink>.</Span><LineBreak></LineBreak>
<Hyperlink NavigateUri="https://developers.arcgis.com/net/security-and-authentication/#api-keys">More info on API Keys</Hyperlink>
<Span>You can get or create an API key as described in <Hyperlink NavigateUri="https://links.esri.com/create-an-api-key">this tutorial</Hyperlink>.</Span>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As above "You can create an API Key access token as..."

@pMaske pMaske requested a review from maryharvey June 22, 2024 01:06
@pMaske
Copy link
Member Author

pMaske commented Jun 26, 2024

@maryharvey please take another look.

maryharvey
maryharvey approved these changes Jun 26, 2024
View reviewed changes
Copy link

@maryharvey maryharvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pMaske Looks good.

@pMaske pMaske merged commit 5032f25 into main Jul 5, 2024
1 check passed
@pMaske pMaske deleted the preeti/update_API_Key_Instructions branch July 5, 2024 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotMorten dotMorten dotMorten approved these changes

@maryharvey maryharvey maryharvey approved these changes

@duffh duffh Awaiting requested review from duffh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pMaske @dotMorten @maryharvey