Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated API key instructions for citra update on June 26th #580

Merged
merged 5 commits into from
Jul 5, 2024
Merged

Updated API key instructions for citra update on June 26th #580

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5ce852c
Updated API key instructions for citra update on June 26th
pMaske Jun 18, 2024
e1535e0
Removed duplicate hyperlinks since it is one tutorial now
pMaske Jun 18, 2024
8af8b24
Removed info link from MAUI
pMaske Jun 18, 2024
9185635
fixed a typo
pMaske Jun 18, 2024
f24d913
Use of words suggest by doc team - API key access token
pMaske Jun 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions src/Samples/Toolkit.SampleApp.Maui/MainPage.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,8 @@
<Label MaxLines="5" Margin="0,10,0,0" >
<Label.FormattedText>
<FormattedString>
<Span Text="You can get or create an API key from " />
<Span Text="your developer dashboard" TextDecorations="Underline" TextColor="{AppThemeBinding Light={StaticResource Blue100Accent}, Dark={StaticResource Blue300Accent}}" >
<Span Text="You can get or create an API key by following" />
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can create an API Key using the Create an api key Tutorial... but you cannot get/copy one after the API Key has been generated. You only get one opportunity to copy it so I would be tempted to just say "You can create an API Key access token by...."

<Span Text="this tutorial" TextDecorations="Underline" TextColor="{AppThemeBinding Light={StaticResource Blue100Accent}, Dark={StaticResource Blue300Accent}}" >
<Span.GestureRecognizers>
<TapGestureRecognizer Tapped="DashboardLinkTapped" />
</Span.GestureRecognizers>
Expand All @@ -46,11 +46,6 @@
</FormattedString>
</Label.FormattedText>
</Label>
<Label MaxLines="5" Margin="0,10,0,0" TextDecorations="Underline" TextColor="{AppThemeBinding Light={StaticResource Blue100Accent}, Dark={StaticResource Blue300Accent}}" Text="More info on API Keys">
<Label.GestureRecognizers>
<TapGestureRecognizer Tapped="MoreInfoLinkTapped" />
</Label.GestureRecognizers>
</Label>
</VerticalStackLayout>
</Border>
</Grid>
Expand Down
7 changes: 1 addition & 6 deletions src/Samples/Toolkit.SampleApp.Maui/MainPage.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,11 +91,6 @@ private async void SaveApiKey_Click(object sender, EventArgs e)

private void DashboardLinkTapped(object sender, TappedEventArgs e)
{
Microsoft.Maui.ApplicationModel.Launcher.OpenAsync("https://developers.arcgis.com/api-keys/");
}

private void MoreInfoLinkTapped(object sender, TappedEventArgs e)
{
Microsoft.Maui.ApplicationModel.Launcher.OpenAsync("https://developers.arcgis.com/net/security-and-authentication/#api-keys");
Microsoft.Maui.ApplicationModel.Launcher.OpenAsync("https://links.esri.com/create-an-api-key");
}
}
3 changes: 1 addition & 2 deletions src/Samples/Toolkit.SampleApp.UWP/MainPage.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,7 @@
Background="CornflowerBlue" Foreground="White"
Click="SaveApiKey_Click" />
<TextBlock TextWrapping="Wrap" Margin="0,10,0,0">
<Span>You can get or create an API key from <Hyperlink NavigateUri="https://developers.arcgis.com/api-keys/">your developer dashboard</Hyperlink>.</Span><LineBreak></LineBreak>
<Hyperlink NavigateUri="https://developers.arcgis.com/net/security-and-authentication/#api-keys">More info on API Keys</Hyperlink>
<Span>You can get or create an API key as described in <Hyperlink NavigateUri="https://links.esri.com/create-an-api-key">this tutorial</Hyperlink>.</Span>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You removed the more-info here and below, but maui still has the more info. Which solution are we going with?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More-info is also not needed any longer. I missed to removed it from MAUI. Just updated the PR. Please review the latest commit.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as above "You can create an API Key access token as described...."

</TextBlock>
</StackPanel>
</Border>
Expand Down
3 changes: 1 addition & 2 deletions src/Samples/Toolkit.SampleApp.WPF/MainWindow.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,7 @@
Click="SaveApiKey_Click"
/>
<TextBlock TextWrapping="Wrap" Margin="0,10,0,0">
<Span>You can get or create an API key from <Hyperlink NavigateUri="https://developers.arcgis.com/api-keys/" RequestNavigate="Hyperlink_RequestNavigate">your developer dashboard</Hyperlink>.</Span><LineBreak></LineBreak>
<Hyperlink NavigateUri="https://developers.arcgis.com/net/security-and-authentication/#api-keys" RequestNavigate="Hyperlink_RequestNavigate">More info on API Keys</Hyperlink>
<Span>You can get or create an API key as described in <Hyperlink NavigateUri="https://links.esri.com/create-an-api-key" RequestNavigate="Hyperlink_RequestNavigate">this tutorial</Hyperlink>.</Span>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As above "You can create an API Key access token as..."

</TextBlock>
</StackPanel>
</Border>
Expand Down
3 changes: 1 addition & 2 deletions src/Samples/Toolkit.SampleApp.WinUI/MainWindow.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,7 @@
Background="CornflowerBlue" Foreground="White"
Click="SaveApiKey_Click" />
<TextBlock TextWrapping="Wrap" Margin="0,10,0,0">
<Span>You can get or create an API key from <Hyperlink NavigateUri="https://developers.arcgis.com/api-keys/">your developer dashboard</Hyperlink>.</Span><LineBreak></LineBreak>
<Hyperlink NavigateUri="https://developers.arcgis.com/net/security-and-authentication/#api-keys">More info on API Keys</Hyperlink>
<Span>You can get or create an API key as described in <Hyperlink NavigateUri="https://links.esri.com/create-an-api-key">this tutorial</Hyperlink>.</Span>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As above "You can create an API Key access token as..."

</TextBlock>
</StackPanel>
</Border>
Expand Down
Loading