Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaking change: Changed from ListView to CollectionView in BookmarksView which resolves ItemTemplate issue in iOS #598

Merged
merged 10 commits into from
Sep 5, 2024
Merged

Breaking change: Changed from ListView to CollectionView in BookmarksView which resolves ItemTemplate issue in iOS #598

merged 10 commits into from
Sep 5, 2024

Commits on Aug 28, 2024

  1. Document known MAUI iOS issue in ItemTemplateChanged

    @prathameshnarkhede
    prathameshnarkhede committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    5afe02c View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2024

  1. Refactor UI: Replace ListView with CollectionView

    @prathameshnarkhede
    prathameshnarkhede committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    475793d View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2024

  1. Refactor BookmarksView to centralize CollectionView updates 

    - This Fixes a bug with Android adding item couple of times when new Bookmark is added.
- Centralize the update logic for the CollectionView in the BookmarksView class by introducing a new `UpdateListView` method.
    @prathameshnarkhede
    prathameshnarkhede committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    4d65c75 View commit details
    Browse the repository at this point in the history

  2. Refactor: centralize "PresentingView" string usage

    @prathameshnarkhede
    prathameshnarkhede committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    4d8c05c View commit details
    Browse the repository at this point in the history

  3. Changing name

    @prathameshnarkhede
    prathameshnarkhede committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    9660568 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2024

  1. Refactor event handling in BookmarksView and DataSource 

    This fixes problem in Android from root level.
    @prathameshnarkhede
    prathameshnarkhede committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    c6d0ccc View commit details
    Browse the repository at this point in the history

  2. Removing unnecessary keyword

    @prathameshnarkhede
    prathameshnarkhede committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    e71bfd7 View commit details
    Browse the repository at this point in the history

  3. Refactor BookmarksView for simplicity and performance

    @prathameshnarkhede
    prathameshnarkhede committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    1f2c020 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2024

  1. Refactor BookmarksView to use class-level CollectionView to maintain … 

    …sequence of detaching and attaching events
    @prathameshnarkhede
    prathameshnarkhede committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    5d2ffa0 View commit details
    Browse the repository at this point in the history

  2. Refactor _presentingView visibility and assignment logic

    @prathameshnarkhede
    prathameshnarkhede committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    8faf76e View commit details
    Browse the repository at this point in the history