Breaking change: Changed from ListView to CollectionView in BookmarksView which resolves ItemTemplate issue in iOS #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstefarov
approved these changes
Aug 30, 2024
prathameshnarkhede
changed the title
mstefarov
approved these changes
Aug 30, 2024
- This Fixes a bug with Android adding item couple of times when new Bookmark is added. - Centralize the update logic for the CollectionView in the BookmarksView class by introducing a new `UpdateListView` method.
dotMorten
requested changes
Sep 3, 2024
This fixes problem in Android from root level.
prathameshnarkhede
changed the title
dotMorten
requested changes
Sep 4, 2024
…sequence of detaching and attaching events
dotMorten
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug is related to Bookmarks updating template does not apply on all rows for iOS.
MAUI Bug Reported dotnet/maui#24492
EDIT:
Found that changing to
CollectionViewactually solves this issue and I was able to test it on Windows, iOS and Android platforms.There is going to be a breaking change for
ItemTemplatesCells used forCollectionView.