Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaking change: Changed from ListView to CollectionView in BookmarksView which resolves ItemTemplate issue in iOS #598

Merged
merged 10 commits into from
Sep 5, 2024
Merged

Breaking change: Changed from ListView to CollectionView in BookmarksView which resolves ItemTemplate issue in iOS #598

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
5afe02c
Document known MAUI iOS issue in ItemTemplateChanged
prathameshnarkhede Aug 28, 2024
475793d
Refactor UI: Replace ListView with CollectionView
prathameshnarkhede Aug 30, 2024
4d65c75
Refactor BookmarksView to centralize CollectionView updates
prathameshnarkhede Sep 3, 2024
4d8c05c
Refactor: centralize "PresentingView" string usage
prathameshnarkhede Sep 3, 2024
9660568
Changing name
prathameshnarkhede Sep 3, 2024
c6d0ccc
Refactor event handling in BookmarksView and DataSource
prathameshnarkhede Sep 4, 2024
e71bfd7
Removing unnecessary keyword
prathameshnarkhede Sep 4, 2024
1f2c020
Refactor BookmarksView for simplicity and performance
prathameshnarkhede Sep 4, 2024
5d2ffa0
Refactor BookmarksView to use class-level CollectionView to maintain …
prathameshnarkhede Sep 5, 2024
8faf76e
Refactor _presentingView visibility and assignment logic
prathameshnarkhede Sep 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/Toolkit/Toolkit.Maui/BookmarksView/BookmarksView.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,9 @@ private static void GeoViewChanged(BindableObject sender, object? oldValue, obje
/// </summary>
private static void ItemTemplateChanged(BindableObject sender, object? oldValue, object? newValue)
{
// MAUI Bug: Custom Control ItemTemplate fails to change at runtime in MAUI iOS
// GitHub Issue: #24492 (https://github.com/dotnet/maui/issues/24492)

BookmarksView bookmarkView = (BookmarksView)sender;

if (bookmarkView._presentingView != null)
Expand Down
Loading