Open
Conversation
harkon666
approved these changes
Jan 2, 2026
|
|
||
| }; | ||
| let hasil = ""; | ||
| for (let i = 0; i < str.length; i++) { |
Contributor
There was a problem hiding this comment.
Sebenernya start i = 1 dan i < str.length - 1 itu juga solusi yg lebih clean dan tanpa perlu if else
Contributor
There was a problem hiding this comment.
Tapi good job, ini juga termasuk benar
Contributor
There was a problem hiding this comment.
Ini sebenernya bisa lebih clean kalau if else modulus nya didalam loop j
Contributor
There was a problem hiding this comment.
Jadi ga perlu for loop yang redundan (dipakai berulang) di dalam if
Contributor
There was a problem hiding this comment.
Overal jawaban benar, jadi lanjutkan, diatas hanya review
Contributor
There was a problem hiding this comment.
Ini juga berlaku ketimbang codenya jadi panjang karena di dalam if else ada loop, better cukup nested loop dan isinya cuma if else, lebih clean code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.