-
Notifications
You must be signed in to change notification settings - Fork 11
dicek ya sir #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
dicek ya sir #1
Changes from all commits
53dc8b7
f2ec0ab
603dbfd
c504c1a
aafd3d5
9f6f924
3511112
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ini sebenernya bisa lebih clean kalau if else modulus nya didalam loop j
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Jadi ga perlu for loop yang redundan (dipakai berulang) di dalam if
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Overal jawaban benar, jadi lanjutkan, diatas hanya review |
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ini juga berlaku ketimbang codenya jadi panjang karena di dalam if else ada loop, better cukup nested loop dan isinya cuma if else, lebih clean code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sebenernya start i = 1 dan i < str.length - 1 itu juga solusi yg lebih clean dan tanpa perlu if else
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tapi good job, ini juga termasuk benar