feat: show correct message for users with enableRestrictedPrimaryLogin security group#83080
feat: show correct message for users with enableRestrictedPrimaryLogin security group#83080Eskalifer1 wants to merge 2 commits intoExpensify:mainfrom
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
|
@jayeshmangwani Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
JmillsExpensify
left a comment
There was a problem hiding this comment.
PR maps to intended product spec.
Explanation of Change
This PR updates the logic for displaying the message about changing the default email. Previously, everyone saw the text that they could change the default contact method, even those who could not do so due to the security group. This has been fixed in this PR. Now, those who can change the default contact method see the message that was there before, and those who cannot see the corresponding message.
Fixed Issues
$#82194
PROPOSAL:#76106 (comment)
Tests
Prerequisites: Log in with Expensify account (not Gmail account)
Offline tests
Same as tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
2026-02-20.17.47.52.mov
Android: mWeb Chrome
82194-android-web.mov
iOS: Native
82194-ios-native.mov
iOS: mWeb Safari
82194-ios-web.mov
MacOS: Chrome / Safari
82194-web.mov