Code Improvements for Downloads

[Martinski4GitHub]

More code improvements when downloading files.

[Martinski4GitHub]

@ExtremeFiretop,

Just a couple of code changes in preparation for the future 1.4.0 release.
BTW, don't worry about the "long list of commits" associated with this PR. I think that happened because I recently synced by 'master' & 'develop' branches which resulted in all these commits coming along for the ride :>).

[ExtremeFiretop]

@ExtremeFiretop,

Just a couple of code changes in preparation for the future 1.4.0 release. BTW, don't worry about the "long list of commits" associated with this PR. I think that happened because I recently synced by 'master' & 'develop' branches which resulted in all these commits coming along for the ride :>).

Hahaha I do the reverse sync pretty often myself, no worries!

Thanks for the suggestions! Did you load up and play with 1.4.0 a bit yet?

[Martinski4GitHub]

@ExtremeFiretop.

Essentially, this PR prepares the code for a new "install" parameter in the next version which will download, install & set up everything that's needed. More info to come soon.

[Martinski4GitHub]

@ExtremeFiretop,
Just a couple of code changes in preparation for the future 1.4.0 release. BTW, don't worry about the "long list of commits" associated with this PR. I think that happened because I recently synced by 'master' & 'develop' branches which resulted in all these commits coming along for the ride :>).

Hahaha I do the reverse sync pretty often myself, no worries!

Thanks for the suggestions! Did you load up and play with 1.4.0 a bit yet?

I actually did and there's a new PR for the "WebFun" branch with all my latest changes. Please take a look when you get a chance.

Some background:
Last Sunday, once my boys had left town (back to their homes), and my wife was busy with other personal stuff, I had a few hours to kill so instead of setting up the new RT-AX86U_PRO router, I decided to take a closer look at your modified and new code :>).

After about 3 hours of focused work on it, I made quite a few changes in both the shell script and the ASP file. A lot of changes were due to reformatting to make it more readable and to conform to our company coding standards (primarily the ASP file which had over 800 warnings after running it through the Linter tool).

Once I completed this first phase of my review, I tested it briefly but I didn't really have enough time to do proper testing & validation before going to bed. On Monday back to work, I talked with my friend about your initial work & plans to have a WebGUI for the script, and he became very interested & excited about it and then he asked if he could be an early "Beta tester."

I told him that it was too early for Beta testing, but I had an early Alpha version that he could take for a spin to give us some objective feedback. So I provided him with the 2 modified files and the steps needed to "install & set up" the new WebGUI ASP file. He has been testing for a couple of evenings and, so far, he's got very good & positive feedback (and also found 3 bugs which I fixed yesterday).

There are still some more changes I'd like to make, mostly improvements & fine-tuning in some areas, but I believe the bulk of the changes have been made (at least based on what I have seen & reviewed so far).

Take care, bud. Talk you you later.

P.S.
BTW, today I was supposed to be working at the office, but our building had a power outage (actually, the entire 4 blocks were affected by the outage), so they told us to go home until further notice.

[ExtremeFiretop]

@ExtremeFiretop,
Just a couple of code changes in preparation for the future 1.4.0 release. BTW, don't worry about the "long list of commits" associated with this PR. I think that happened because I recently synced by 'master' & 'develop' branches which resulted in all these commits coming along for the ride :>).

Hahaha I do the reverse sync pretty often myself, no worries!
Thanks for the suggestions! Did you load up and play with 1.4.0 a bit yet?

I actually did and there's a new PR for the "WebFun" branch with all my latest changes. Please take a look when you get a chance.

Some background: Last Sunday, once my boys had left town (back to their homes), and my wife was busy with other personal stuff, I had a few hours to kill so instead of setting up the new RT-AX86U_PRO router, I decided to take a closer look at your modified and new code :>).

I've seen the new branch and WOW you went hard! Love it! Will take me a while to review this in return hahaha.... Take that time and setup that RT-AX86U!!!

After about 3 hours of focused work on it, I made quite a few changes in both the shell script and the ASP file. A lot of changes were due to reformatting to make it more readable and to conform to our company coding standards (primarily the ASP file which had over 800 warnings after running it through the Linter tool).

Did you ever! You easily turned this PoC from PoC to alpha/beta level! It's like watching someone come in and redo your homework, my mouth is jaw dropped! It looks absolutely beautiful!

Once I completed this first phase of my review, I tested it briefly but I didn't really have enough time to do proper testing & validation before going to bed. On Monday back to work, I talked with my friend about your initial work & plans to have a WebGUI for the script, and he became very interested & excited about it and then he asked if he could be an early "Beta tester."

I told him that it was too early for Beta testing, but I had an early Alpha version that he could take for a spin to give us some objective feedback. So I provided him with the 2 modified files and the steps needed to "install & set up" the new WebGUI ASP file. He has been testing for a couple of evenings and, so far, he's got very good & positive feedback (and also found 3 bugs which I fixed yesterday).

That's no problem! I'm happy so many people seem to like the idea, I haven't heard any negative feedback from my friends or anyone in the forums, hearing your friend be excited to beta test also tells me maybe there's enough of a desire for this out in the wild to pursue this more.

There are still some more changes I'd like to make, mostly improvements & fine-tuning in some areas, but I believe the bulk of the changes have been made (at least based on what I have seen & reviewed so far).

Take care, bud. Talk you you later.

No rush! Like I mentioned it may take me a while to load it up and go through all the changes but just quickly it looks amazing!

P.S. BTW, today I was supposed to be working at the office, but our building had a power outage (actually, the entire 4 blocks were affected by the outage), so they told us to go home until further notice.

Crazy! My government building had a bug problem and sent everyone home lol, I have a story of my own to tell you but I'll share in the forums, I don't need this one being a story on the news xD

[Martinski4GitHub]

@ExtremeFiretop,
Just a couple of code changes in preparation for the future 1.4.0 release. BTW, don't worry about the "long list of commits" associated with this PR. I think that happened because I recently synced by 'master' & 'develop' branches which resulted in all these commits coming along for the ride :>).

Hahaha I do the reverse sync pretty often myself, no worries!
Thanks for the suggestions! Did you load up and play with 1.4.0 a bit yet?

I actually did and there's a new PR for the "WebFun" branch with all my latest changes. Please take a look when you get a chance.
Some background: Last Sunday, once my boys had left town (back to their homes), and my wife was busy with other personal stuff, I had a few hours to kill so instead of setting up the new RT-AX86U_PRO router, I decided to take a closer look at your modified and new code :>).

I've seen the new branch and WOW you went hard! Love it! Will take me a while to review this in return hahaha.... Take that time and setup that RT-AX86U!!!

I'll set up the new router over the weekend. I don't like to do it during the workweek because I need something reliable and well-tested to pass the scans done by our IT folks. Once I set up the new router, I'll have to notify them to do a scan if I want to continue to work from home, even just a couple of days per week.

After about 3 hours of focused work on it, I made quite a few changes in both the shell script and the ASP file. A lot of changes were due to reformatting to make it more readable and to conform to our company coding standards (primarily the ASP file which had over 800 warnings after running it through the Linter tool).

Did you ever! You easily turned this PoC from PoC to alpha/beta level! It's like watching someone come in and redo your homework, my mouth is jaw dropped! It looks absolutely beautiful!

Once I completed this first phase of my review, I tested it briefly but I didn't really have enough time to do proper testing & validation before going to bed. On Monday back to work, I talked with my friend about your initial work & plans to have a WebGUI for the script, and he became very interested & excited about it and then he asked if he could be an early "Beta tester."
I told him that it was too early for Beta testing, but I had an early Alpha version that he could take for a spin to give us some objective feedback. So I provided him with the 2 modified files and the steps needed to "install & set up" the new WebGUI ASP file. He has been testing for a couple of evenings and, so far, he's got very good & positive feedback (and also found 3 bugs which I fixed yesterday).

That's no problem! I'm happy so many people seem to like the idea, I haven't heard any negative feedback from my friends or anyone in the forums, hearing your friend be excited to beta test also tells me maybe there's enough of a desire for this out in the wild to pursue this more.

Yeah, I also got the sense that many users would like to see a WebGUI page as well. I think the vast majority of regular users are not very comfortable using the SSH CLI and not being familiar with Linux, it seems kind of scary for some people.

There are still some more changes I'd like to make, mostly improvements & fine-tuning in some areas, but I believe the bulk of the changes have been made (at least based on what I have seen & reviewed so far).
Take care, bud. Talk you you later.

No rush! Like I mentioned it may take me a while to load it up and go through all the changes but just quickly it looks amazing!

Oh yeah, take your time. There is a boatload of "changes" due to the reformatting as well. So there's no rush at all. The more thorough we are with our reviews, and the more testing is done, the better. There is no pressure or timeframe to get this out to the wild anytime soon, so we can take our time to do it right.

P.S. BTW, today I was supposed to be working at the office, but our building had a power outage (actually, the entire 4 blocks were affected by the outage), so they told us to go home until further notice.

Crazy! My government building had a bug problem and sent everyone home lol, I have a story of my own to tell you but I'll share in the forums, I don't need this one being a story on the news xD

LOL!!!