Skip to content

Change Layout For Single Save Button#428

Merged
Martinski4GitHub merged 7 commits intoExtremeFiretop-Cleanup-Changelogfrom
ExtremeFiretop-ChangeLayout
Mar 23, 2025
Merged

Change Layout For Single Save Button#428
Martinski4GitHub merged 7 commits intoExtremeFiretop-Cleanup-Changelogfrom
ExtremeFiretop-ChangeLayout

Conversation

@ExtremeFiretop
Copy link
Owner

@ExtremeFiretop ExtremeFiretop commented Mar 21, 2025

Change layout for a single save button:

  1. It's caused confusion/user error for maghuro
  2. Dave commentted it doesn't follow the standards: https://www.snbforums.com/threads/merlinau-v1-3-10-the-ultimate-firmware-auto-updater-gnuton-support.91326/post-946568
  3. vlord requested it as well: https://www.snbforums.com/threads/merlinau-v1-3-10-the-ultimate-firmware-auto-updater-gnuton-support.91326/post-948545

Frankly; I don't care enough to say no forever. So be it :)

image

ChangeLayout
@ExtremeFiretop ExtremeFiretop changed the title ChangeLayout Change Layout For Single Save Button Mar 21, 2025
@Martinski4GitHub
Copy link
Collaborator

Change layout for a single save button:

1. It's caused confusion/user error for [maghuro](https://www.snbforums.com/members/maghuro.67697/)

2. Dave commentted it doesn't follow the standards: https://www.snbforums.com/threads/merlinau-v1-3-10-the-ultimate-firmware-auto-updater-gnuton-support.91326/post-946568

3. vlord requested it as well: https://www.snbforums.com/threads/merlinau-v1-3-10-the-ultimate-firmware-auto-updater-gnuton-support.91326/post-948545

Frankly; I don't care enough to say no forever. So be it :)

Either the "original" layout (i.e. with separate "Save" buttons), or the new layout works for me. To be clear, I saw nothing wrong with the original way, but I have no real preference or favorite. Either layout is good enough & works for the WebGUI page.

@ExtremeFiretop
Copy link
Owner Author

Change layout for a single save button:

1. It's caused confusion/user error for [maghuro](https://www.snbforums.com/members/maghuro.67697/)

2. Dave commentted it doesn't follow the standards: https://www.snbforums.com/threads/merlinau-v1-3-10-the-ultimate-firmware-auto-updater-gnuton-support.91326/post-946568

3. vlord requested it as well: https://www.snbforums.com/threads/merlinau-v1-3-10-the-ultimate-firmware-auto-updater-gnuton-support.91326/post-948545

Frankly; I don't care enough to say no forever. So be it :)

Either the "original" layout (i.e. with separate "Save" buttons), or the new layout works for me. To be clear, I saw nothing wrong with the original way, but I have no real preference or favorite. Either layout is good enough & works for the WebGUI page.

Personally; I had zero issues with the original layout either.
But it seems users expect a single save button. It might be easier for mobiles. And it's been requested twice so considering I honestly and truly don't care I changed it. It only ended up the original way because it only developed that way as I was playing and learning with the project.

Copy link
Collaborator

@Martinski4GitHub Martinski4GitHub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Job. Approved!!!

@Martinski4GitHub Martinski4GitHub merged commit 69f5f07 into ExtremeFiretop-Cleanup-Changelog Mar 23, 2025
1 check passed
@ExtremeFiretop ExtremeFiretop deleted the ExtremeFiretop-ChangeLayout branch March 23, 2025 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants