Skip to content

Minor Fixes and Additions#451

Merged
Martinski4GitHub merged 7 commits intodevfrom
ExtremeFiretop-SmallFixes
Apr 10, 2025
Merged

Minor Fixes and Additions#451
Martinski4GitHub merged 7 commits intodevfrom
ExtremeFiretop-SmallFixes

Conversation

@ExtremeFiretop
Copy link
Owner

Minor Fixes and Additions

@ExtremeFiretop
Copy link
Owner Author

ExtremeFiretop commented Apr 9, 2025

@Martinski4GitHub

1. This fixes some nitpicks of the WebUI:

-Previous:
image

-New:
image

2. Fixes a few small things with shell script:
-After you set the Router PWD; add a successfully tested or unvalidated result to main menu

image

-Change the wording for the update process to fix nitpicks related to "anyways" vs "anyway"
-Update Minimum Versions to 3 behind production
-Add FW_New_Update_Changelog_Approval="TBD" On First Install to fix the WebUI status for the changelog approval.

Post fresh install it currently looks like this even though the changelog check is enabled:

image
image

Adding the value to TBD fixes this for new installs:

image

@ExtremeFiretop ExtremeFiretop added bug Something isn't working enhancement New feature or request labels Apr 9, 2025
@Martinski4GitHub
Copy link
Collaborator

You certainly were busy today with MerlinAU!! LOL!!
I'll take a look at this PR either tomorrow evening or within the following days. I had a very busy and long day at work today, so I'm feeling tired and sleepy right now. As I mentioned before, we have a major release coming up, so the workload can get hectic from one day to the next.

Anyway, have a good night, bud!!

Copy link
Collaborator

@Martinski4GitHub Martinski4GitHub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good.

@Martinski4GitHub Martinski4GitHub merged commit 75e7a11 into dev Apr 10, 2025
1 check passed
@ExtremeFiretop
Copy link
Owner Author

Looking good.

All small things. Nothing that's a show stopper by any means

@Martinski4GitHub
Copy link
Collaborator

Looking good.

All small things. Nothing that's a show stopper by any means

Yeah, I get it. Sometimes our personal OCDs need to be satisfied too!!! LOL!!!

BTW, it's time to run the latest code through the Linter tool just to make sure we keep the code "clean."
Also, I'm making a couple of code improvements; a new PR to be submitted shortly.

@ExtremeFiretop
Copy link
Owner Author

Looking good.

All small things. Nothing that's a show stopper by any means

Yeah, I get it. Sometimes our personal OCDs need to be satisfied too!!! LOL!!!

BTW, it's time to run the latest code through the Linter tool just to make sure we keep the code "clean." Also, I'm making a couple of code improvements; a new PR to be submitted shortly.

If the linter tool turns around and says we need to rip it all out and redo it all I will be jaw dropped 😭 😉

@ExtremeFiretop ExtremeFiretop deleted the ExtremeFiretop-SmallFixes branch April 11, 2025 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants