Merged
Conversation
Some additional code improvements.
Collaborator
Author
|
Linter tool came back with a very good report: Found no errors and no new warnings. Please review the PR when you have time. Nothing urgent, so there's no rush. Take your time. Sample screenshot showing the Password "verified" status in green:
|
ExtremeFiretop
approved these changes
Apr 10, 2025
Owner
|
All good to go! I like the idea to turn the text green if it's verified. It looks good and less flashy to the eyes 😂 |
Collaborator
Author
Yeah, I think so, and it fits our expectations of green color indicating an "All Good" status. Other colors (e.g. red, purple, magenta, yellow) instinctively trigger our notion of "Is something missing?" or "Did something go wrong?" despite what the words say. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some additional code improvements.