Fix and Improvements#454
Merged
ExtremeFiretop merged 1 commit intoExtremeFiretop:devfrom Apr 12, 2025
Merged
Conversation
- Fixed bug introduced in PR ExtremeFiretop#453 which was allowing installation in all unsupported models. - Miscellaneous code improvements.
Owner
|
Actually not a bug but by design. Has it get installed to be uninstalled. |
Owner
|
I believe you might have the impression the unsupported models should stop the install? If we were to do your method were it blocks install completely we could remove this Or this? |
Owner
|
Reply from user: Post in thread 'MerlinAU v1.4.1 - The Ultimate Firmware Auto-Updater (GNUTON SUPPORT!)' https://www.snbforums.com/threads/merlinau-v1-4-1-the-ultimate-firmware-auto-updater-gnuton-support.91326/post-951249 |
Owner
|
All good to go! Merging 🥇 |
ExtremeFiretop
approved these changes
Apr 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.