Fixes and Code Improvements

[Martinski4GitHub]

Improved uninstallation workflow when users attempt to install MerlinAU on unsupported routers.

Now the code will automatically prompt users to uninstall immediately after informing them that their current router model is unsupported. In such scenarios, this provides users a quick & easy way to uninstall.

Sample screenshots

User answers NO to the automatic prompt to uninstall:

User answers YES to uninstall:

[ExtremeFiretop]

@Martinski4GitHub

Sorry for the delay buddy. I saw this yesterday but didn't get around to testing it. Will get to that today though!

[ExtremeFiretop]

Tested; vetted and verified!

All good and merging! I tested the flow with an actual completed "install" of the script
(i.e a script installed previously from AMTM with the previous unsupported method which allowed a full install)

And a manually copy of the script
(i.e only the .sh file and nothing else present; not a fully install):

[Martinski4GitHub]

@Martinski4GitHub

Sorry for the delay buddy. I saw this yesterday but didn't get around to testing it. Will get to that today though!

Ah, no worries. There was nothing urgent. It was just a little enhancement to make it easier to uninstall in specific cases.

[Martinski4GitHub]

Tested; vetted and verified!

All good and merging! I tested the flow with an actual completed "install" of the script (i.e a script installed previously from AMTM with the previous unsupported method which allowed a full install)

And a manually copy of the script (i.e only the .sh file and nothing else present; not a fully install):

Excellent!!! Thank you for the additional test & validation.

[ExtremeFiretop]

@Martinski4GitHub
Sorry for the delay buddy. I saw this yesterday but didn't get around to testing it. Will get to that today though!

Ah, no worries. There was nothing urgent. It was just a little enhancement to make it easier to uninstall in specific cases.

I got to it! Don't worry; I told you I would ;)
I also won over the dealership, or so it looks like:

Did you want to issue a 1.4.2 release with these additional bug fixes and enhancements?

[Martinski4GitHub]

@Martinski4GitHub
Sorry for the delay buddy. I saw this yesterday but didn't get around to testing it. Will get to that today though!

Ah, no worries. There was nothing urgent. It was just a little enhancement to make it easier to uninstall in specific cases.

I got to it! Don't worry; I told you I would ;) I also won over the dealership, or so it looks like:

Man, that's good to hear!! Sounds like your persistence worked in your favor. I know dealing with car dealerships can be a real pain in the butt. I've had my share of bad experiences, so it's always good to hear when a customer finally wins.

Did you want to issue a 1.4.2 release with these additional bug fixes and enhancements?

Yeah, sounds good. And just in time before the production version of the 3006.102.4 F/W (currently in Beta) gets released to the wild.

[ExtremeFiretop]

@Martinski4GitHub
Sorry for the delay buddy. I saw this yesterday but didn't get around to testing it. Will get to that today though!

Ah, no worries. There was nothing urgent. It was just a little enhancement to make it easier to uninstall in specific cases.

I got to it! Don't worry; I told you I would ;) I also won over the dealership, or so it looks like:

Man, that's good to hear!! Sounds like your persistence worked in your favor. I know dealing with car dealerships can be a real pain in the butt. I've had my share of bad experiences, so it's always good to hear when a customer finally wins.

They were flat out refusing to submit my claim to the Genesis Warranty claims admin/process. I was jaw dropped. Was like since when do the dealerships make the final decision? Dealership acting like the judge, jury and executioner! And they think they can get away with it because even though it's a Hyundai brand, Genesis cars need to be serviced by "certified" techs at their own dealerships and it's the only one within a driving distance.

Did you want to issue a 1.4.2 release with these additional bug fixes and enhancements?

Yeah, sounds good. And just in time before the production version of the 3006.102.4 F/W (currently in Beta) gets released to the wild.

I think it's a good idea. Just taking 15 minutes break to eat dinner. But will be back shortly to prepare the PRs!

[Martinski4GitHub]

@Martinski4GitHub
Sorry for the delay buddy. I saw this yesterday but didn't get around to testing it. Will get to that today though!

Ah, no worries. There was nothing urgent. It was just a little enhancement to make it easier to uninstall in specific cases.

I got to it! Don't worry; I told you I would ;) I also won over the dealership, or so it looks like:

Man, that's good to hear!! Sounds like your persistence worked in your favor. I know dealing with car dealerships can be a real pain in the butt. I've had my share of bad experiences, so it's always good to hear when a customer finally wins.

They were flat out refusing to submit my claim to the Genesis Warranty claims admin/process. I was jaw dropped. Was like since when do the dealerships make the final decision? Dealership acting like the judge, jury and executioner! And they think they can get away with it because even though it's a Hyundai brand, Genesis cars need to be serviced by "certified" techs at their own dealerships and it's the only one within a driving distance.

I think sometimes it's the management at the dealerships. They just like to be total a-holes about doing car repairs, especially when the cost is being shared between the dealer and the manufacturer due to the warranties.

Did you want to issue a 1.4.2 release with these additional bug fixes and enhancements?

Yeah, sounds good. And just in time before the production version of the 3006.102.4 F/W (currently in Beta) gets released to the wild.

I think it's a good idea. Just taking 15 minutes break to eat dinner. But will be back shortly to prepare the PRs!

Yeah, OK. I'll be called to dinner in about 30 minutes or so, but I'll be checking my messages before and after dinner.