Skip to content

Patch WebUI#475

Merged
Martinski4GitHub merged 6 commits intodevfrom
Patch-WebUI
May 19, 2025
Merged

Patch WebUI#475
Martinski4GitHub merged 6 commits intodevfrom
Patch-WebUI

Conversation

@ExtremeFiretop
Copy link
Owner

@ExtremeFiretop ExtremeFiretop commented May 18, 2025

  1. Gray out Install Script checkbox if Auto updates is enabled.

  2. Changed the wording if Auto updates are enabled.

  3. ChangeLog in the WebUI cannot by browsed by direction keys

  4. Allow Changelog function to detect migration of code base from 3004 to 3006 firmware.

  5. Adjust Script Version

Issues Resolved:

1. Gray out Install Script checkbox if Auto updates is enabled.
2. Changed the wording if Auto updates are enabled.
4. ChangeLog in the WebUI cannot by browsed by direction keys
Changes:
1. Allow Changelog function to detect migration of code base from 3004 to 3006 firmware.
Resolved:
1. Only warn and do not hard blocking setting credential's even if Web Access Restrictions is enabled.
Was originally discussed in this post:

#292 (comment)
Adjust Script Version
@ExtremeFiretop ExtremeFiretop marked this pull request as ready for review May 18, 2025 23:48
@ExtremeFiretop ExtremeFiretop added bug Something isn't working enhancement New feature or request labels May 18, 2025
@ExtremeFiretop
Copy link
Owner Author

ExtremeFiretop commented May 18, 2025

As for why these aren't working as expected for him?

#294
#295

No idea; I recently tested and it seemed to work for me.

This is to deal with these reports:
https://www.snbforums.com/threads/merlinau-v1-4-6-the-ultimate-firmware-auto-updater-webui-gnuton-support.91326/post-955935

@ExtremeFiretop
Copy link
Owner Author

ExtremeFiretop commented May 19, 2025

As @ExtremeFiretop is well aware, I usually go offline for many long hours at a time (e.g. 16 to 20 hours every day), especially during my workdays, but also during the weekends, depending on things going on at work and my personal life, but I usually respond as needed within 24 to 48 hours. Just FYI, so you know what to expect WRT my response times.

@Martinski4GitHub

Exactly why I didn't wait for you on the last release when all it was was flipping a 0 to 1 hahaha ;)
But this one is more involved and I'd like your opinion on the reported web restrictions issue

@Martinski4GitHub
Copy link
Collaborator

As for why these aren't working as expected for him?

#294 #295

No idea; I recently tested and it seemed to work for me.

This is to deal with these reports: https://www.snbforums.com/threads/merlinau-v1-4-6-the-ultimate-firmware-auto-updater-webui-gnuton-support.91326/post-955935

The changes in the ASP file look really good to go.

However, before making any changes regarding the "WebUI Access Restrictions" check, I'd like to fully understand the specific issues the poster is experiencing/observing so we can have a clearer and better idea about how to address those issues. Otherwise, you're reacting based on assumptions and perhaps misinterpretations of the issues being reported.

I see you've already requested from the poster more information with logs and screenshots to get more context and to try to understand what the poster is talking about. I'd say we wait until we know more about how to proceed.

My 2 cents.

@ExtremeFiretop ExtremeFiretop changed the title Patch WebUI and Resolve Web Access Restrictions Patch WebUI May 19, 2025
@ExtremeFiretop
Copy link
Owner Author

Think I'm getting tired. Was a busy day. I'll probably be heading to bed but I'll check your new additions in the morning to OSR!

Goodnight buddy

@Martinski4GitHub
Copy link
Collaborator

Think I'm getting tired. Was a busy day. I'll probably be heading to bed but I'll check your new additions in the morning to OSR!

Goodnight buddy

OK, bud, have a good night and sleep tight!!! :>)
I'll be going to bed in about half an hour or so myself, so I don't think I'll be making any changes/additions to the AMTM OSR repos. I'm getting tired too, and I can feel my brain not running at "100% full throttle" already. I'll leave things for another day.

Copy link
Collaborator

@Martinski4GitHub Martinski4GitHub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@Martinski4GitHub Martinski4GitHub merged commit cece920 into dev May 19, 2025
3 checks passed
@ExtremeFiretop ExtremeFiretop deleted the Patch-WebUI branch May 19, 2025 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants