Feature/fix usergroup update #60
Merged
+34
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nshandra
requested changes
Oct 2, 2024
src/data/user-monitoring/permission-fixer/PermissionFixerUserGroupD2Repository.ts
Outdated
Show resolved
Hide resolved
src/data/user-monitoring/permission-fixer/PermissionFixerUserGroupD2Repository.ts
Outdated
Show resolved
Hide resolved
src/data/user-monitoring/permission-fixer/PermissionFixerUserGroupD2Repository.ts
Show resolved
Hide resolved
src/data/user-monitoring/permission-fixer/PermissionFixerUserGroupD2Repository.ts
Outdated
Show resolved
Hide resolved
ifoche
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…usergroup
User permission fixer was adding to the WIDP USERS group all the users without group. But was overriding the userGroup sharing settings, also was using the endpoint that broke our instances.
I have changed from post the full userGroup to addition in the usergroup the missing users
I tested it in a local instance using:
yarn start usermonitoring run-permissions-fixer --config-file config.json