Feature/select g house #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Karyum
approved these changes
Jun 4, 2017
jbesraa
requested changes
Jun 5, 2017
src/components/search_list.jsx
Outdated
| {props.db.map((guestHouses) => { | ||
| const boundItemClick = handleClick.bind(this, guestHouses.name); | ||
| return ( | ||
| <button |
There was a problem hiding this comment.
maybe this button should be a different component and then the bind function wont be inside the map function
src/containers/select_guesthouse.jsx
Outdated
| currentGuestHouse(guestHouse) { | ||
| const current = this.state.db.filter((curr) => { | ||
| if (curr.name === guestHouse) { | ||
| return curr; |
|
@esraajb more like this? 🍁 |
jbesraa
requested changes
Jun 6, 2017
|
|
||
|
|
||
| class SelectGuesthouse extends Component { | ||
| constructor(props) { | ||
| super(props); | ||
| this.state = { | ||
| db: {}, | ||
| title: 'PAS', | ||
| tagLine: 'Park & Sleep', |
There was a problem hiding this comment.
are title and tagLine ever change? if not, then its pointless to put them in a state.
There was a problem hiding this comment.
They are going to be changed (header will update based on these values). Next PR.
src/containers/select_guesthouse.jsx
Outdated
| db: {}, | ||
| title: 'PAS', | ||
| tagLine: 'Park & Sleep', | ||
| db: [], |
There was a problem hiding this comment.
maybe instead of db, use 'guestHousesList'? might be clearer for the reader
|
@esraajb ref #22 was in the commit messages 😄 should it be in the comment as well? Changes made. |
|
Yea, should be in the description |
|
@esraajb Cool cool, done. And will do going forward. Good to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #22