-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/select g house #34
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
cfae191
Replace search bar with search list
philawsophizing 513a60b
Set state with data from the database, current guesthouse ref #22
philawsophizing 16ca391
Fix var naming, split out button component, ref #22
philawsophizing e42b09d
Add search button component ref #22
philawsophizing 01c2d4f
Improve naming in state ref #22
philawsophizing File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
import React from 'react'; | ||
|
||
const SearchButton = (props) => { | ||
const handle = () => { | ||
props.clickHandler(props.currentGHouse); | ||
}; | ||
|
||
return ( | ||
<button onClick={handle}>{props.currentGHouse}</button> | ||
); | ||
}; | ||
export default SearchButton; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
import React from 'react'; | ||
import SearchButton from './search_button.jsx'; | ||
|
||
const SearchList = props => | ||
( | ||
<div> | ||
{props.db.map(guestHouses => | ||
// const boundItemClick = handleClick.bind(this, guestHouses.name); | ||
<SearchButton | ||
key={guestHouses.name} | ||
clickHandler={props.updateCurrent} | ||
currentGHouse={guestHouses.name} | ||
/>, | ||
)} | ||
</div> | ||
); | ||
|
||
export default SearchList; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are title and tagLine ever change? if not, then its pointless to put them in a state.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are going to be changed (header will update based on these values). Next PR.