Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates cicd + Raman Reader #1

Merged
merged 11 commits into from
Jul 8, 2024
Merged

Updates cicd + Raman Reader #1

merged 11 commits into from
Jul 8, 2024

Conversation

domna
Copy link
Collaborator

@domna domna commented Jul 2, 2024

No description provided.

@domna domna requested a review from RonHildebrandt July 2, 2024 13:34
@RonHildebrandt
Copy link
Collaborator

Sounds good, as far as I can judge this.

RonHildebrandt
RonHildebrandt approved these changes Jul 3, 2024
View reviewed changes
Copy link
Collaborator

@RonHildebrandt RonHildebrandt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, in workflows, this defines how the testing is done.
as well the switch to pynxtools-plugins was done as far as I can see.

looks good to me.

@RonHildebrandt RonHildebrandt changed the title Updates cicd Updates cicd + Raman Reader Jul 4, 2024
@RonHildebrandt RonHildebrandt mentioned this pull request Jul 8, 2024
Closed
4 tasks
RonHildebrandt
RonHildebrandt approved these changes Jul 8, 2024
View reviewed changes
Copy link
Collaborator

@RonHildebrandt RonHildebrandt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, with that the first version for the Raman reader can be published.
Two datasets were included. Output is in accord with nexus def from workshop updates.
Adjustements for the testing were necessary

@RonHildebrandt RonHildebrandt merged commit 6b55c95 into main Jul 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RonHildebrandt RonHildebrandt RonHildebrandt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@domna @RonHildebrandt