Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test branch changes pre-event and changes during the event #9

Merged
merged 28 commits into from
Mar 20, 2024

Conversation

shinthebinn
Copy link
Member

  • Added passing functionality
  • Actual auto routines
  • Limelights are barely working, took out game piece functionality and replaced distance shooting with a passing function
  • Manual note reset
  • Default arm reset position changed to 40 degrees from 4 to reduce breakage
  • Put a couple tooltips (shooter @ speed, holding note) on shuffleboard
  • Manual reset for notes
  • Intake has a slight (15 ms) delay on cancel to make sure notes are completely intaked
  • Climber added
  • New SetScoringPosition command. Can take in either the new ScoringPosition data type (a record that represents arm angle and shooter speed) or a function that supplies a ScoringPosition

Copy link
Contributor

@carahegadorn carahegadorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a bunch of comments - most were questions, but I think lights will need a change after we index a note out of the robot. I think there is an arm encoder offset that might not be a problem - but it's hard coded and also in constants - so confusing.

approving because I don't see anything bad enough to cause a major problem as far as I can tell

@carahegadorn carahegadorn merged commit 23e3e3d into main Mar 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants