Open
Conversation
Neoforge PR: neoforged/NeoForge#2969 This is to cover how vanilla has 2 item frame variants now. Might help other mods that add more variants like a light-source item frame or gamer RGB item frame.
cassiancc
reviewed
Feb 13, 2026
Member
cassiancc
left a comment
cassiancc
left a comment
There was a problem hiding this comment.
Looks good, wrote some JavaDocs that have been added to the Neo side already.
...s-v2/src/main/java/net/fabricmc/fabric/api/tag/convention/v2/ConventionalEntityTypeTags.java
Show resolved
Hide resolved
…i/tag/convention/v2/ConventionalEntityTypeTags.java Co-authored-by: Cassian Godsted <cassian@godsted.com>
cassiancc
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Neoforge PR: neoforged/NeoForge#2969
This is to cover how vanilla has 2 item frame variants now. Might help other mods that add more variants like a light-source item frame or gamer RGB item frame.