Skip to content

Add entitytype tag for item frames#2969

Open
Commoble wants to merge 3 commits intoneoforged:port/26.1from
Commoble:add-entity-type-tag-for-item-frames
Open

Add entitytype tag for item frames#2969
Commoble wants to merge 3 commits intoneoforged:port/26.1from
Commoble:add-entity-type-tag-for-item-frames

Conversation

@Commoble
Copy link
Contributor

@Commoble Commoble commented Feb 12, 2026

There's two entitytypes for item frames now, regular item frames and glow item frames. This puts both in one tag:

//data/c/tags/entity_type/item_frames.json
{
  "values": [
    "minecraft:item_frame",
    "minecraft:glow_item_frame"
  ]
}

@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Feb 12, 2026

  • Publish PR to GitHub Packages

@TelepathicGrunt
Copy link
Contributor

TelepathicGrunt commented Feb 12, 2026

Dont forget to add tag lang translation too

TelepathicGrunt added a commit to TelepathicGrunt/fabric that referenced this pull request Feb 12, 2026
@TelepathicGrunt
Add c:item_frames entity tag
932faeb 
Neoforge PR: neoforged/NeoForge#2969

This is to cover how vanilla has 2 item frame variants now. Might help other mods that add more variants like a light-source item frame or gamer RGB item frame.
@TelepathicGrunt TelepathicGrunt mentioned this pull request Feb 12, 2026
Open
@TelepathicGrunt
Copy link
Contributor

TelepathicGrunt commented Feb 12, 2026

Fabric PR: FabricMC/fabric-api#5203

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Commoble @TelepathicGrunt