refactor: adopt same code conventions as kafkaflow #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luispfgarces
previously approved these changes
Dec 15, 2023
added 8 commits
December 19, 2023 09:22
|
@luispfgarces rebased. |
luispfgarces
approved these changes
Dec 19, 2023
martinhonovais
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As discussed with @luispfgarces, this PR applies the same code conventions adopted by KafkaFlow v3 (Farfetch/kafkaflow#475 and Farfetch/kafkaflow#485).
.slnfile to roottestsfolder_as private field prefixHow Has This Been Tested?
Run automated tests.
Checklist
Disclaimer
By sending us your contributions, you are agreeing that your contribution is made subject to the terms of our Contributor Ownership Statement