Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: preserve message context items when SetMessage is called #534

Merged
merged 1 commit into from
Mar 1, 2024
Merged

fix: preserve message context items when SetMessage is called #534

merged 1 commit into from
Mar 1, 2024

Conversation

esskar
Copy link
Contributor

@esskar esskar commented Feb 27, 2024 •
edited
Loading

Description

When the message context is changed by using SetMessage, the Items on the context are lost. This change preserves the original Items

How Has This Been Tested?

I added a unit test

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have added tests to cover my changes
  • I have made corresponding changes to the documentation

Disclaimer

By sending us your contributions, you are agreeing that your contribution is made subject to the terms of our Contributor Ownership Statement

@esskar
Copy link
Contributor Author

esskar commented Feb 27, 2024

Thanks for the review. Is there an ETA for it to be released?

@JoaoRodriguesGithub JoaoRodriguesGithub merged commit 4f79c43 into Farfetch:master Mar 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelfoliveira joelfoliveira joelfoliveira approved these changes

@lpcouto lpcouto lpcouto approved these changes

@simaoribeiro simaoribeiro simaoribeiro approved these changes

@ruiqbarbosa ruiqbarbosa ruiqbarbosa approved these changes

@JoaoRodriguesGithub JoaoRodriguesGithub JoaoRodriguesGithub approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@esskar @joelfoliveira @lpcouto @simaoribeiro @ruiqbarbosa @JoaoRodriguesGithub